Re: KFENCE: included in x86 defconfig?

[Matthieu Baerts <matttbe@kernel.org>]

On 07/02/2024 20:04, Borislav Petkov wrote:
> On Wed, Feb 07, 2024 at 07:35:53PM +0100, Matthieu Baerts wrote:
>> Sorry, I'm sure I understand your suggestion: do you mean not including
>> KFENCE in hardening.config either, but in another one?
>>
>> For the networking tests, we are already merging .config files, e.g. the
>> debug.config one. We are not pushing to have KFENCE in x86 defconfig, it
>> can be elsewhere, and we don't mind merging other .config files if they
>> are maintained.
> 
> Well, depends on where should KFENCE be enabled? Do you want people to
> run their tests with it too, or only the networking tests? If so, then
> hardening.config probably makes sense. 
> 
> Judging by what Documentation/dev-tools/kfence.rst says:
> 
> "KFENCE is designed to be enabled in production kernels, and has near zero
> performance overhead."
> 
> this reads like it should be enabled *everywhere* - not only in some
> hardening config.
> 
> But then again I've never played with it so I don't really know.
> 
> If only the networking tests should enable it, then it should be a local
> .config snippet which is not part of the kernel.
> 
> Makes more sense?

Yes, thank you!

On my side, KFENCE is currently in local .config snippet, not part of
the kernel. If it has near zero performance overhead and can be used in
productions kernel, maybe it can be set elsewhere to be used by more
people? But not everywhere, according to Marco.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.