From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD45C3E8C5 for ; Sun, 29 Nov 2020 17:35:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A3F922240 for ; Sun, 29 Nov 2020 17:35:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OcFNQ8Q0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728533AbgK2Rfg (ORCPT ); Sun, 29 Nov 2020 12:35:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36270 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728469AbgK2Rff (ORCPT ); Sun, 29 Nov 2020 12:35:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606671248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Baf2YabTsa2IfZZmu8SPbdZascUUB96+ibE6qUCU1Gc=; b=OcFNQ8Q0Cd66CIJO+fd/hzSsFKTxj7yn/w3Ki3tEzQXczI7jT73cO1CXLE5JNvmZ6rIYTg 5xB1fMDsU+CaTUd1QWtapL2wFrZxQMyCHbDnZBumLxmXlKbuF2MNI1RdsfX2011faP474+ AivSLGSkSnZLMDee2sHzRNovMaRYFOs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-rbg69PREOPSzTD5hi4jY7g-1; Sun, 29 Nov 2020 12:34:06 -0500 X-MC-Unique: rbg69PREOPSzTD5hi4jY7g-1 Received: by mail-wr1-f70.google.com with SMTP id w17so6976961wrl.8 for ; Sun, 29 Nov 2020 09:34:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Baf2YabTsa2IfZZmu8SPbdZascUUB96+ibE6qUCU1Gc=; b=V0D1u4t1fS8TYmW5zRMlpHtGI5eVSiZeGZEI/EKFWCeqDegoj5RLUC6NPURFyHOKDS vrVwVvIpr9T2pTAilOJtQKNOFaeQdjTk9LQ8Hse2uPjehs/jjFHfUVCzdXKbDIQ6oOmB /6g4/fiGtBdhMg327Ajvb1BIPBoSWUNEDC3ZPZv3x3XLF2CzkhTUaUjomXTytFr03OHj p9OJHspiBM0VGpEgDhicKQKWKIFfAzIgjCZAXXBGZMUG/GfZJKZxgA/pTvlekEMY4N4E NmDSdHgUExRUQupacjcKv8JJG5SLsQiYA15lHW2XoavcaEhXEqkeV74ZDeW0ZgFsppV+ BNGQ== X-Gm-Message-State: AOAM533G2miaY/lIAvlXX+nRnT/v9VsOrtV9eyuL5ROnkg/U4TuCmSeY CQYLu82g+Fg/Zl3XIcrCkG7ex/BhWkeeiL7leRINbNnAyQ1I6szBdwp/z9yU1pUJjTbHL387EZt EJwPjpPq7BhlJG0ad1RV0NZKNtY1+eE7nKP0JrMQVCbSEG1xtaCvhF31ESX5Q0ppY+wml X-Received: by 2002:a1c:4d0a:: with SMTP id o10mr19426275wmh.107.1606671245327; Sun, 29 Nov 2020 09:34:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJy21n5+1MquKPMw6OBo6U5LqUAw3wOmx072b/JbOC0N0bjRNE96mnvZ3UYX3LcDBBupYSjL2g== X-Received: by 2002:a1c:4d0a:: with SMTP id o10mr19426239wmh.107.1606671244962; Sun, 29 Nov 2020 09:34:04 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id m4sm4842595wmi.41.2020.11.29.09.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Nov 2020 09:34:04 -0800 (PST) Subject: Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mike Christie , Jason Wang , "Michael S . Tsirkin" , Stefan Hajnoczi , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org References: <20201125153550.810101-1-sashal@kernel.org> <20201125153550.810101-22-sashal@kernel.org> <25cd0d64-bffc-9506-c148-11583fed897c@redhat.com> <20201125180102.GL643756@sasha-vm> <9670064e-793f-561e-b032-75b1ab5c9096@redhat.com> <20201129041314.GO643756@sasha-vm> From: Paolo Bonzini Message-ID: <7a4c3d84-8ff7-abd9-7340-3a6d7c65cfa7@redhat.com> Date: Sun, 29 Nov 2020 18:34:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201129041314.GO643756@sasha-vm> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 29/11/20 05:13, Sasha Levin wrote: >> Which doesn't seem to be suitable for stable either...  Patch 3/5 in > > Why not? It was sent as a fix to Linus. Dunno, 120 lines of new code? Even if it's okay for an rc, I don't see why it is would be backported to stable releases and release it without any kind of testing. Maybe for 5.9 the chances of breaking things are low, but stuff like locking rules might have changed since older releases like 5.4 or 4.19. The autoselection bot does not know that, it basically crosses fingers that these larger-scale changes cause the patches not to apply or compile anymore. Maybe it's just me, but the whole "autoselect stable patches" and release them is very suspicious. You are basically crossing fingers and are ready to release any kind of untested crap, because you do not trust maintainers of marking stable patches right. Only then, when a backport is broken, it's maintainers who get the blame and have to fix it. Personally I don't care because I have asked you to opt KVM out of autoselection, but this is the opposite of what Greg brags about when he touts the virtues of the upstream stable process over vendor kernels. Paolo >> the series might be (vhost scsi: fix cmd completion race), so I can >> understand including 1/5 and 2/5 just in case, but not the rest.  Does >> the bot not understand diffstats? > > Not on their own, no. What's wrong with the diffstats? >