From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next] net: phy: convert further flags in struct phy_device to bit-field Date: Thu, 24 May 2018 16:03:22 -0700 Message-ID: <7a4cd053-74aa-17a9-1ce2-da4e3ae21809@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Heiner Kallweit , Andrew Lunn , David Miller Return-path: Received: from mail-qk0-f194.google.com ([209.85.220.194]:39495 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935346AbeEXXDc (ORCPT ); Thu, 24 May 2018 19:03:32 -0400 Received: by mail-qk0-f194.google.com with SMTP id z75-v6so2684372qkb.6 for ; Thu, 24 May 2018 16:03:32 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/24/2018 01:15 PM, Heiner Kallweit wrote: > This patch is a follow-up to 87e5808d52b6 ("net: phy: replace bool > members in struct phy_device with bit-fields") and converts further > flags to bit-fields. This looks fine, but then you would also have to clean-up all code that does phydev->asym_pause = 1 and phydev->pause = 1 to use true/false instead, I am not sure there is much value in doing that for these fields considering that they are exposed to drivers so there is a risk of possible breakage. Thanks! > > Signed-off-by: Heiner Kallweit > --- > include/linux/phy.h | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 6cd090984..cc66f2834 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -418,21 +418,20 @@ struct phy_device { > /* The most recently read link state */ > unsigned link:1; > > + /* forced speed & duplex (no autoneg) > + * partner speed & duplex & pause (autoneg) > + */ > + unsigned pause:1; > + unsigned asym_pause:1; > + int speed; > + int duplex; > + > enum phy_state state; > > u32 dev_flags; > > phy_interface_t interface; > > - /* > - * forced speed & duplex (no autoneg) > - * partner speed & duplex & pause (autoneg) > - */ > - int speed; > - int duplex; > - int pause; > - int asym_pause; > - > /* Enabled Interrupts */ > u32 interrupts; > > -- Florian