From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next 2/3] mnl: add fallback implementation for mnl_attr_get_uint()
Date: Tue, 17 Mar 2026 20:31:15 -0600 [thread overview]
Message-ID: <7a9b746d-96ee-4100-8849-9ee2e9773366@gmail.com> (raw)
In-Reply-To: <z4jw6f4asfzbvlxad7owwws7zwfns4gi2k56bmnfb4c6t2dbm2@4wrw7nals4r6>
On 3/17/26 2:17 AM, Jiri Pirko wrote:
> Mon, Mar 16, 2026 at 05:12:45PM +0100, stephen@networkplumber.org wrote:
>> On Mon, 16 Mar 2026 16:44:17 +0100
>> Jiri Pirko <jiri@resnulli.us> wrote:
>>
>>> From: Jiri Pirko <jiri@nvidia.com>
>>>
>>> libmnl introduced mnl_attr_get_uint() to handle NLA_UINT
>>> variable-width attributes. Add a configure check to detect it
>>> and provide a fallback implementation for older libmnl versions.
>>>
>>> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>>
>> How far back was this? If it was relatively recent would
>> prefer not adding another set of config tests.
>
> https://git.netfilter.org/libmnl/commit/?id=102942be401a99943b2c68981b238dadfa788f2d
>
> I'm not sure what you suggest as alternative...
that is less than 1 stable release cycle. I think we should keep the
configure probe and fallback.
next prev parent reply other threads:[~2026-03-18 2:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 15:44 [PATCH iproute2-next 0/3] devlink: show devlink instance index in dev output Jiri Pirko
2026-03-16 15:44 ` [PATCH iproute2-next 1/3] update kernel headers Jiri Pirko
2026-03-16 15:44 ` [PATCH iproute2-next 2/3] mnl: add fallback implementation for mnl_attr_get_uint() Jiri Pirko
2026-03-16 16:12 ` Stephen Hemminger
2026-03-17 8:17 ` Jiri Pirko
2026-03-18 2:31 ` David Ahern [this message]
2026-03-16 15:44 ` [PATCH iproute2-next 3/3] devlink: show devlink instance index in dev output Jiri Pirko
2026-03-23 0:20 ` [PATCH iproute2-next 0/3] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a9b746d-96ee-4100-8849-9ee2e9773366@gmail.com \
--to=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox