From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v3 5/5] net: dsa: factor skb freeing on xmit
Date: Thu, 1 Jun 2017 13:14:18 -0700 [thread overview]
Message-ID: <7aa57651-0bdb-730e-2dff-f0b2d2e94532@gmail.com> (raw)
In-Reply-To: <20170601200715.8438-6-vivien.didelot@savoirfairelinux.com>
On 06/01/2017 01:07 PM, Vivien Didelot wrote:
> As of a86d8becc3f0 ("net: dsa: Factor bottom tag receive functions"),
> the rcv caller frees the original SKB in case or error.
>
> Be symmetric with that and make the xmit caller do the same.
>
> At the same time, fix the checkpatch NULL comparison check:
>
> CHECK: Comparison to NULL could be written "!nskb"
> #208: FILE: net/dsa/tag_trailer.c:35:
> + if (nskb == NULL)
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
I must have not read the patch correctly the first time, because my
objection no longer stands, this looks much cleaner now, thanks!
--
Florian
next prev parent reply other threads:[~2017-06-01 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 20:07 [PATCH net-next v3 0/5] net: dsa: tagger simplification Vivien Didelot
2017-06-01 20:07 ` [PATCH net-next v3 1/5] net: dsa: comment hot path requirements Vivien Didelot
2017-06-01 20:07 ` [PATCH net-next v3 2/5] net: dsa: do not cast dst Vivien Didelot
2017-06-01 20:07 ` [PATCH net-next v3 3/5] net: dsa: remove dsa_uses_tagged_protocol Vivien Didelot
2017-06-01 20:07 ` [PATCH net-next v3 4/5] net: dsa: remove out_drop label in taggers rcv Vivien Didelot
2017-06-01 20:07 ` [PATCH net-next v3 5/5] net: dsa: factor skb freeing on xmit Vivien Didelot
2017-06-01 20:14 ` Florian Fainelli [this message]
2017-06-01 21:36 ` [PATCH net-next v3 0/5] net: dsa: tagger simplification David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aa57651-0bdb-730e-2dff-f0b2d2e94532@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).