From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73F283F661D for ; Mon, 27 Jul 2026 10:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785146851; cv=none; b=LiEf/0rNqZlGpmdQiSlJRLFxvxEAl3ANEVb+p94/P6QKZBnmirnIa2A0OyR+tN+sTL70HZv3bD3hjpmdrOs13XEDAt6As5DR1yxQSR0K9ZDj8avYe8y4W+GmkRnkXA5/6gtw27NryYML5Shebx5G67RWB0sD5mihgvec0NzCWWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785146851; c=relaxed/simple; bh=E15XfPG0XLJ/CQ6hsaGL76B/E+9/n45ilK578TAed5E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oZKALTNDrcV027oMkzssc3TNXi7tjouJj9v3okDX2DRaVIoCWwoXtnwJZWJ/z8qkPwYe/c/PUNiSIQ/gEpC1fWa2CHAw22dbTXyhrbMaLFkLVBcT/nzWUrJfP8KuBX/UTk8PbfKM0abLjhFOSFl6EnE8MSHl+eM8kRN8pNDHPH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=phq/sV4b; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y0vcZT7E; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="phq/sV4b"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y0vcZT7E" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66R9aR2O3333764 for ; Mon, 27 Jul 2026 10:07:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S1N2mWIMe9XAYKGa9HXnaqIztknAlWljoYw1v6FDc68=; b=phq/sV4blnifXumr 8eBPUZfxbQqSY8HaTuCiy+ruRUfE5p306L0K/W7JZe/+3TBS+jTpDDDGOtHgHQ83 y7qk/FqNvdhNrWUV2Vm2OmEJYYhYa3CWP/Akp3hKLD2cqzww75wg3OWrjA+6r4dN n70NxaqUCLTxLUV14KwjOrBAHTinl7P6v+n9UiJRDJVhe9QvmmnUhJZgReh52mfV K2nh3N9UyZawn5al6zx0oOWMpCroUV2jw4suvjVofsxtcG5ls1pPORzm9ZnX814O w8Pl3d82HHchd/i9dUoWi2DGuiRKqv9/uAywnDJAljGtJVicl1A66olwVpBxdUO1 ekupzg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fp4ukr42h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Jul 2026 10:07:28 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8f21e4e8b66so6538476d6.3 for ; Mon, 27 Jul 2026 03:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785146848; x=1785751648; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=S1N2mWIMe9XAYKGa9HXnaqIztknAlWljoYw1v6FDc68=; b=Y0vcZT7EC8lwdWwK6SES/IPvVGNTL/IKD8Ee+8xRr03HBeDmnocfvl/M0LCsdM/Tcm W3Ad65xjDAME4LWdezO09u/exX+hHgb25Lxpu4XNbNoaTDj7xsf/a9eAuehgOEQkoxwM Y6C2lY33X02GUG8PDtW3+cQTFT4gTt2U8BTfjvTlU6WIOGE/Jq3ywmbpYVVA8ZA1M+e5 e0tXq7wwxyh4Vi04DokJWIYIkvosMaEgPmOBpIf8PjdioeBo1G767Aj6cxbLRkUvZSQa KTnG3p8JGUNBJa2/JKXEhivj9AnejeuvPUmrXdBA0Gd5AYHb84lW9WdCgjlJibuF0P7M v6iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785146848; x=1785751648; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S1N2mWIMe9XAYKGa9HXnaqIztknAlWljoYw1v6FDc68=; b=d5M2CYhQc+DTZEE8NpJ0DvqZ0jbPSFAX7vkpBxijuHnlgiVz681JHrIkH4FG5cjs+7 UmSorucqsaUoC2gU/49ubQGGTq8zSNAx7SDFiU53Wn3x5xTiY1h9gfEP1w39yDFRQgvH X7TpFgUVH4agLaTRLKfJUxmSLkqH1qnFmm2cnmanQZ4IjJiJxPu5TDDuBvpseJ8EQ1by VkDthFV738F+UlchZXhz7GBDHIaLm8uBh3iKd8hZ4XWPX96CgrR4u6D4WkRs5DWaW9Ch OmW0FjW5v8eqUNfZY1b5Z5259aZOVM4tln5Ir/NPTKkdFqKbdU6/Mm4QCmMeolrJD/zf Y82Q== X-Forwarded-Encrypted: i=1; AHgh+Rp3NWFeQZZ+vLUXxuiYrtH9+8fDPb4vQPxkC0AeiHfkUPFYvywn9KN/IVqdknnk2hFHhkwlTmA=@vger.kernel.org X-Gm-Message-State: AOJu0YxFREt4pHQ+qDM18Sq1Y2SsjN9cxUJPIHGWrFDp/zJBrJ1K7FGR X/bT7J2hI26+FBiQOf2+dNJx1h/Q38nnTG7DKvK1sDuSFYmkk7jbnBVE4UV6MQLl61aIUqRjEQR ko3oRx1gEUui4zAYEVoLb92E0Y+ZLqSGnA6vpYWlKZDLUpxTuemNSI2F52roV6NHE02U= X-Gm-Gg: AR+sD11ePB+XcCfKot+VsPWI47B68PxY1sxSiaYaebT97Z1j9p0bgyWB6WdSHBJZnjY 5Gzjjt7wWmZRHOFbsObLBBKIAfA6X/QDQTatoYpLjUc3awnFqZvrUIrWkutrON5jBetptoHJbM+ MnapmjgsZmhLFnBazgdGdE2PUu8KR36o0BmPGqRCMqsJsAdhc5Hj7sZi5imXwmUSrBWyBEZnyp8 mD3KJBSS3n2orr36pSsgbm9tAqqw9s8NiCxwT5Rjz9ohBQ6K/bz5P0Qk+FKAudiHfilHFvJqPyH NR1DJxiq5fFsRPpJ52ikzI7rSyW4bd9gNHh9nQMt9opabqXVht+b5upRbllZIn25t/6cfMGYbfT 8IrHWSVrPMbSmw/rQOojtcrZx X-Received: by 2002:a05:620a:2728:b0:930:aff2:b1e8 with SMTP id af79cd13be357-932df77da40mr625326585a.8.1785146847650; Mon, 27 Jul 2026 03:07:27 -0700 (PDT) X-Received: by 2002:a05:620a:2728:b0:930:aff2:b1e8 with SMTP id af79cd13be357-932df77da40mr625322285a.8.1785146847138; Mon, 27 Jul 2026 03:07:27 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69fb5746e08sm2376666a12.23.2026.07.27.03.07.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 03:07:26 -0700 (PDT) Message-ID: <7ab0655a-52ac-4b15-9223-753c146a9469@oss.qualcomm.com> Date: Mon, 27 Jul 2026 12:07:22 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: milos-fairphone-fp6: Add NFC To: Jorijn van der Graaf , David Heidelberg , Krzysztof Kozlowski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Luca Weiss , oe-linux-nfc@lists.linux.dev, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260726222405.153008-1-jorijnvdgraaf@catcrafts.net> <20260726222405.153008-6-jorijnvdgraaf@catcrafts.net> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260726222405.153008-6-jorijnvdgraaf@catcrafts.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 1eUsWe0X4KPIe0UgXLfUwUq6BFqcbxBF X-Proofpoint-ORIG-GUID: 1eUsWe0X4KPIe0UgXLfUwUq6BFqcbxBF X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI3MDA5OCBTYWx0ZWRfXwi0+L0PhKWx1 4m0Oe4vuydN9Q/ydGCwAG2DJfiXnM5ICzmXZGefwHu6Rcn3dgatjYX8hDqgJ8L8MS8/AJazk1Xd Qgiup22c9jH9amAPy8qf5mVB8nSUL0w= X-Authority-Analysis: v=2.4 cv=PeHPQChd c=1 sm=1 tr=0 ts=6a672de0 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=GYSh3LzNAAAA:8 a=yBwHqnpkDyRxZW_GFQcA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=lWcdFasyL5yHfcDTNXXo:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI3MDA5OCBTYWx0ZWRfX95iZMMG9wfzc 01TlEMwGghrXu7Ug84BmOD52YE5Vfcnt4Iaw7qzORlADYZK4CHEfkYk6DDBNGsSQo5TA0LMW2Y0 yaXMVRZyb783ZG7z9uFT61xZv8+AV0jZTY3ccxTG93wrfd3uE8p4bSxD1Ij5/zAv0/zGmO/WVIk jii+vd9TR6zxPg1zEp/TNDk1oPgxJk+PsTFrzXdCNhYIK0ij0CuLyo+RzKkkGrb+1WNN4uN0EKk W6xgYUeXtW9OOVkakENxQyhKWY64eeJm8tPgPuAFjgxuC2lKwdlbvG3KuJEA3Ca38M5lu7yGKDY dnoMPKKiaNLYR9rkY7hlxqMG9gMvc3wSXpNnR9nNFqBVd8kEm3ZQHwnVMwjGq8v2nWzKnPGjNqQ 42Phj0RqpzxoFnInmo886/IDTECKcvkqDRmpMXSr7liLJYh9nNvgtT0iNAIR9foCOrhzKowhjdp cQnu6U3oXyvMd7oNO5w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-27_02,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607270098 On 7/27/26 12:24 AM, Jorijn van der Graaf wrote: > Add the Samsung S3NRN4V NCI NFC controller on i2c1. Its XI clock is > provided by the RF_CLK2 PMIC buffer and gated through the controller's > CLK_REQ line on tlmm GPIO6. PVDD is fed from PM7550 LDO20, the rail the > downstream driver switches for this chip. > > The enable line is routed to the chip's power-down input, which is > asserted high to turn the chip off (the downstream driver treats VEN as > active-low on this design) -- hence GPIO_ACTIVE_HIGH, unlike the > exynos5433-tm2 wiring of the same driver. The pin is pulled up so the > chip stays off while the line is not driven. > > Assisted-by: Claude:claude-opus-4-8 > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Jorijn van der Graaf > --- > .../boot/dts/qcom/milos-fairphone-fp6.dts | 49 ++++++++++++++++++- > 1 file changed, 47 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > index ebdca0e2d2f3..a1b86e4092fe 100644 > --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts > @@ -601,9 +601,29 @@ &gcc { > }; > > &i2c1 { > - /* Samsung NFC @ 0x27 */ > - > status = "okay"; > + > + /* > + * Samsung S3NRN4V NFC controller. XI is driven by the RF_CLK2 PMIC > + * buffer; the chip has no oscillator of its own and gates the clock > + * via its CLK_REQ line, so the clock must be voted on in response > + * to it. > + */ This seems like something that's more fitting of the commit message and/or dt-bindings (either description: or in a YAML comment) > + nfc@27 { > + compatible = "samsung,s3nrn4v"; > + reg = <0x27>; > + > + clk-req-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > + clocks = <&rpmhcc RPMH_RF_CLK2>; > + en-gpios = <&tlmm 56 GPIO_ACTIVE_HIGH>; > + interrupt-parent = <&tlmm>; > + interrupts = <31 IRQ_TYPE_EDGE_RISING>; interrupts-extended = <&tlmm 31 IRQ..> > + pinctrl-0 = <&nfc_clk_req_default>, <&nfc_irq_default>, > + <&nfc_pd_default>; You can create a group of pins (see below > + pinctrl-names = "default"; > + pvdd-supply = <&vreg_l20b>; > + wake-gpios = <&tlmm 7 GPIO_ACTIVE_HIGH>; Please group the -gpios properties together > + }; > }; > > &i2c3 { > @@ -825,6 +845,31 @@ &tlmm { > <13 1>, /* NC */ > <63 2>; /* WLAN UART */ > > + nfc_clk_req_default: nfc-clk-req-default-state { > + pins = "gpio6"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + nfc_irq_default: nfc-irq-default-state { > + pins = "gpio31"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + /* > + * Pulled up so the NFC chip stays powered down while the line is > + * not driven (it is the chip's active-high power-down input). > + */ > + nfc_pd_default: nfc-pd-default-state { > + pins = "gpio56"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; You can group them into something like: nfc_default_state: nfc-default-state { nfc-clk-req-default-pins { gpios = "" ... }; ... }; Konrad