From: David Ahern <dsahern@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 22/22] rdma: make local functions static
Date: Tue, 20 Nov 2018 15:26:17 -0700 [thread overview]
Message-ID: <7ab55e41-edfd-ff2d-9a2c-8c749db63086@gmail.com> (raw)
In-Reply-To: <20181115223640.411-23-stephen@networkplumber.org>
On 11/15/18 3:36 PM, Stephen Hemminger wrote:
> Several functions only used inside utils.c
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> rdma/rdma.h | 11 -----------
> rdma/utils.c | 12 ++++++------
> 2 files changed, 6 insertions(+), 17 deletions(-)
>
this patch breaks builds for me on Debian stretch:
rdma
CC rdma.o
CC utils.o
CC dev.o
CC link.o
dev.c: In function 'dev_set_name':
dev.c:248:6: warning: implicit declaration of function 'rd_no_arg'
[-Wimplicit-function-declaration]
if (rd_no_arg(rd)) {
^~~~~~~~~
dev.c:256:55: warning: implicit declaration of function 'rd_argv'
[-Wimplicit-function-declaration]
mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, rd_argv(rd));
^~~~~~~
dev.c:256:55: warning: passing argument 3 of 'mnl_attr_put_strz' makes
pointer from integer without a cast [-Wint-conversion]
In file included from rdma.h:19:0,
from dev.c:12:
/usr/include/libmnl/libmnl.h:103:13: note: expected 'const char *' but
argument is of type 'int'
extern void mnl_attr_put_strz(struct nlmsghdr *nlh, uint16_t type,
const char *data);
Reverting the patch fixes it.
next prev parent reply other threads:[~2018-11-21 8:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 22:36 [PATCH iproute2 00/22] misc cleanups Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 01/22] lib/ll_addr: whitespace and indent cleanup Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 02/22] lib/utils: make local functions static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 03/22] lib/color: " Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 04/22] lib/ll_map: make local function static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 05/22] libnetlnk: unused and local functions cleanup Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 06/22] genl: remove dead code Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 07/22] bridge: make local variables static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 08/22] ip: make flag names const/static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 09/22] ipmonitor: make local variable static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 10/22] ipxfrm: make local functions static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 11/22] tc: drop unused name_to_id function Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 12/22] tipc: make cmd_find static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 13/22] tc/class: make filter variables static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 14/22] tc/police: make print_police static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 15/22] ss: make local variables static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 16/22] tc/pedit: make functions static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 17/22] tc/ematch: make local " Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 18/22] tc/util: " Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 19/22] tc/meta: make meta_table static and const Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 20/22] tc/action: make variables static Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 21/22] tc/pedit: use structure initialization Stephen Hemminger
2018-11-15 22:36 ` [PATCH iproute2 22/22] rdma: make local functions static Stephen Hemminger
2018-11-20 22:26 ` David Ahern [this message]
2018-11-17 23:19 ` [PATCH iproute2 00/22] misc cleanups David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ab55e41-edfd-ff2d-9a2c-8c749db63086@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).