From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2 22/22] rdma: make local functions static Date: Tue, 20 Nov 2018 15:26:17 -0700 Message-ID: <7ab55e41-edfd-ff2d-9a2c-8c749db63086@gmail.com> References: <20181115223640.411-1-stephen@networkplumber.org> <20181115223640.411-23-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Stephen Hemminger , netdev@vger.kernel.org Return-path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:45314 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbeKUI5n (ORCPT ); Wed, 21 Nov 2018 03:57:43 -0500 Received: by mail-pl1-f195.google.com with SMTP id a14so2337051plm.12 for ; Tue, 20 Nov 2018 14:26:20 -0800 (PST) In-Reply-To: <20181115223640.411-23-stephen@networkplumber.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/15/18 3:36 PM, Stephen Hemminger wrote: > Several functions only used inside utils.c > > Signed-off-by: Stephen Hemminger > --- > rdma/rdma.h | 11 ----------- > rdma/utils.c | 12 ++++++------ > 2 files changed, 6 insertions(+), 17 deletions(-) > this patch breaks builds for me on Debian stretch: rdma CC rdma.o CC utils.o CC dev.o CC link.o dev.c: In function 'dev_set_name': dev.c:248:6: warning: implicit declaration of function 'rd_no_arg' [-Wimplicit-function-declaration] if (rd_no_arg(rd)) { ^~~~~~~~~ dev.c:256:55: warning: implicit declaration of function 'rd_argv' [-Wimplicit-function-declaration] mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, rd_argv(rd)); ^~~~~~~ dev.c:256:55: warning: passing argument 3 of 'mnl_attr_put_strz' makes pointer from integer without a cast [-Wint-conversion] In file included from rdma.h:19:0, from dev.c:12: /usr/include/libmnl/libmnl.h:103:13: note: expected 'const char *' but argument is of type 'int' extern void mnl_attr_put_strz(struct nlmsghdr *nlh, uint16_t type, const char *data); Reverting the patch fixes it.