From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA538C43381 for ; Sun, 24 Feb 2019 17:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF52120663 for ; Sun, 24 Feb 2019 17:01:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ed3C0yRB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728466AbfBXRB1 (ORCPT ); Sun, 24 Feb 2019 12:01:27 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38875 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728179AbfBXRB1 (ORCPT ); Sun, 24 Feb 2019 12:01:27 -0500 Received: by mail-wr1-f67.google.com with SMTP id v13so7368759wrw.5 for ; Sun, 24 Feb 2019 09:01:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=KxRwwMuwkTgYhJlGK7ixSy8+WIwmiQlEv9A/1KNfJZs=; b=Ed3C0yRBbB9a5g3cDD6QutZfQJUXQYlsw1TITQUk5Tp+MJTlfF1f6+IsKenlndMsTb 456DI+6XP8VIBsPRfnQQDVpPVdNwwqRmKfzOwbJtJqk/Ig6H+IBFNCOdH1turKNKVSwj UpeuzSB/Kryctl0mYTS2KhbPjFQzhQUjuwlMhsOpTy4m1D+WuvtkYDz9OE+AOr0eu15p z+tOf9w94qSHJM3/T2Jpos0I6TcptHphv/weFF5ipuE2vNRHB9rwYPemYr76zWlQpOe6 aFQIja44UNoB4taAGfeNmx3HxjUN5y3A74grMP0fH23SxWLM0n27Tv7x0NrkIAb/WlTt EiKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=KxRwwMuwkTgYhJlGK7ixSy8+WIwmiQlEv9A/1KNfJZs=; b=hpblHmc2e/DcKS3xAIOxIfGaHx013RFjHu2HpK22I6cnxdhznfh9C66gR6XfqT/9b/ Sz75dY0DP+TaS4R+oEI3MNRKpi8kxFdWuDbXzB2TDuVJIegwFE6bBwoi0ILuYqQ0elTY 5scFZix/IA3f849IQ3RxESWAmCF10Ql00OzYaFATlkHxEOcQvYfvzhMB4tXq1xvLHsJS HFBKBTo1hEhEYfjpdbLoyu7S5LJNw1SnPTLNbWKyltU/Zq2ldJuG32Y/Q1OEGGgOLm8F 1dgcjJ8EO+ptQcF5LpISUbguLFynABgL4yGdL5ruHJYpzXSI2Prtg0XeyUylcsFFA4mg OdPA== X-Gm-Message-State: AHQUAuYzVu8kuMgp5D/A7sW95Qk1q2Ev7MnF9XZPnMSkbOznC6TXLaWa CxjNPqHZjYZtyOEDyX7KJjeA1ayd X-Google-Smtp-Source: AHgI3IaJbZIQfokN/j9uDI+ElgN+Dna35MMgv0ecDkuYA0TMBV5yX7yja6Xx/raB71+EJZJkxR3KJg== X-Received: by 2002:a05:6000:124d:: with SMTP id j13mr5374847wrx.102.1551027685416; Sun, 24 Feb 2019 09:01:25 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:1133:81d:72d3:c59f? (p200300EA8BF1E2001133081D72D3C59F.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:1133:81d:72d3:c59f]) by smtp.googlemail.com with ESMTPSA id c14sm8919073wrn.12.2019.02.24.09.01.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Feb 2019 09:01:24 -0800 (PST) From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" Subject: [PATCH net] net: phy: fix reading fixed phy status Message-ID: <7ab8732d-bcc1-cc49-4bc8-34826e78038b@gmail.com> Date: Sun, 24 Feb 2019 18:01:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org With the switch to phy_resolve_aneg_linkmode() we don't read from the chip any longer what is advertised but use phydev->advertising directly. For a fixed phy however this bitmap is empty so far, what results in no common mode being found. This breaks DSA. Fix this by advertising everything that is supported. For a normal phy this done by phy_probe(). Fixes: 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") Signed-off-by: Heiner Kallweit --- drivers/net/phy/fixed_phy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index b0d1368c3..1acd8bfdb 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -22,6 +22,7 @@ #include #include #include +#include #include "swphy.h" @@ -300,6 +301,8 @@ static struct phy_device *__fixed_phy_register(unsigned int irq, phy->supported); } + linkmode_copy(phy->advertising, phy->supported); + ret = phy_device_register(phy); if (ret) { phy_device_free(phy); -- 2.20.1