From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45D4614291E for ; Tue, 2 Jul 2024 07:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.14 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719904114; cv=fail; b=Mg45SHVB5vr0fFFRfbYDjv0BLQJtpA32jj/TV7cw5NUnkpjSGuM5cQEjrumxZWUAfm52uXZdGpeCAOxCpzQ40cUHSqd/GZoAn49gFjTYhDHoj3hfzhMIEDJdfRfBmpN508/Uc3EKzDIX4aNgx1D6iRYF6D+vJ7A/Kr7AD0ARu9U= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719904114; c=relaxed/simple; bh=cQ2+qib9IJXUvCBTFZExib4JM7usMgH/fpduW/5OtKw=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=VHHUKpri1awUK1S/tDZ/16UFpXwjuNH+V4SL1dy29GiKNAVHcpVgqoRqXU8qWWb8QAPE1H5mIBeWvY4B73cBh4wdJGJWR25/NSwEbgsPufeNu3/kj602XHHio+WyeRdZGFlx1EPkuS79gChBvBSkY9SMtWHh1uk8jedaIQ82Up4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cJ6nK0e+; arc=fail smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cJ6nK0e+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719904112; x=1751440112; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=cQ2+qib9IJXUvCBTFZExib4JM7usMgH/fpduW/5OtKw=; b=cJ6nK0e+mRxb3N3Jhw18d+6tgiIgQG70fkQJujeHiyA5S+s4XcYJNYZk QFRkrwi0SNPFzWu5jZdpFB4JOLPgytvWan0XT1TvMwP69Or72HZ+hB675 1d7r6OMZ32qQpREVYI7J1zWpgv2OvuxmSjzWCeUwgoyROjpjzvSPUhC0m +ptyHZcLJN1r+EICQS2y4WpS3ba0otlZXcgoKtIUg1qG10DpkHigg+jgp aQKrv1wHZrHcy+FeZ4GumIAu4YArXrDuUbe027em9zWb3DFWAQmuZ4VQt a/c9VXe/dVH5BkHyytrs4VbHsoJarDhZiHQyG2GWVNjtuaMvRclz1za+L A==; X-CSE-ConnectionGUID: Yj/U8rNJQN2Wb1zuu5WgsA== X-CSE-MsgGUID: tFXS3YzoSrSwF4puNPImIA== X-IronPort-AV: E=McAfee;i="6700,10204,11120"; a="20871931" X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="20871931" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 00:08:31 -0700 X-CSE-ConnectionGUID: SqMnNgtbTvaOzH6zGf9obw== X-CSE-MsgGUID: ew0SgANJR7SJe5hdI1hn6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="50246343" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Jul 2024 00:08:31 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 2 Jul 2024 00:08:31 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 2 Jul 2024 00:08:31 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 2 Jul 2024 00:08:30 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 2 Jul 2024 00:08:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WI+lmtyU+gWZ3S9R7pTvUCx+mFmejiSCFFjp2AQAogB8lAsBIQPFbp29ZDyD7+qFPZpat2Oy0EkjG5IeenJBLnmcRY0M7vwK0EN+vCFWMA62ON73lG/BJOXswCFU37HgR3HKJK5+T4rLOsIb/Cpa8d+fPvIdlY/2MqCQ/NqwWLG2c39jMxYUWjRsuno545n3rit4enUnz2COJ1kc5pJbixI/4R4FCFXXnRtKOw6WASJMfB6t04tVlxSxHa60e+DUoGVraG91A45e4U/8vTiY/UvNHV/nAjRqVMokfGFHDsp/q1Ukic8mZQ70cHs+KdVOPtxh2CTnxPKTO47n4UAThg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7unq5LBS4c+PrcyJxiosu8h4T9JVuWUVDV9zy4wruDs=; b=gBQWfLHjuHfFgfBJOIRnSFC4XHW8dWD4b4WFx00xhL7uWkdm75PndQCmCK2Xn17QYmY3FD0XuVLwD3xyHbVM50V8CYojw3ZYITcELGRCGwnCNh8O/9POQQwgr2MKB2PqSiHKee5pIM0CSdttfN3Ad8qwmS6MduPt/D7ECZwLZkeOZuPrl1yk0FSrI9gqtsbVg/Jf3kk9LImAgExBcKXjCQ3eADIj/eGrGSRsp1TVaPjV5h6yjNofuC8+AVFJVEr069gDhYHUrAs7VJ6JmQK3pals9ffme3hRRN8CMOQzddGEm25F0KRh6KK83lOfoYeek0iSaQnsugYlapR//E0j8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) by IA0PR11MB7330.namprd11.prod.outlook.com (2603:10b6:208:436::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.33; Tue, 2 Jul 2024 07:08:23 +0000 Received: from MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::15b2:ee05:2ae7:cfd6]) by MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::15b2:ee05:2ae7:cfd6%7]) with mapi id 15.20.7719.028; Tue, 2 Jul 2024 07:08:23 +0000 Message-ID: <7ab9435f-e43d-4580-b7d3-18a69f231252@intel.com> Date: Tue, 2 Jul 2024 09:08:17 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/3] mlxsw: Warn about invalid accesses to array fields To: Petr Machata , Ido Schimmel CC: , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , References: From: Przemek Kitszel Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: ZR0P278CA0193.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::23) To MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8102:EE_|IA0PR11MB7330:EE_ X-MS-Office365-Filtering-Correlation-Id: db7f9c7b-2a50-4838-4e27-08dc9a65c2df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aU4zRTVPYzUyVWhiNXNGd0RIcHMzdVpqQzloWi9ZTkt4SGhRVkRTZnEwVHRX?= =?utf-8?B?cHVWdVJ2K3hVSENKZ2Q4Qjh2UW5LVHkzVDExZ1VMM1UzTUk2b3RZajduWFZQ?= =?utf-8?B?V3RlTnFoU0YrVEVrVEdSQ0M2TDdEY3VXUi9OdldCaUxSZ1psUElrenk0TWhS?= =?utf-8?B?UllNelc0cHg2REVEaHFwZFN4OEN2OEdudDRBUklOWDk3M0hMMW5oL1RsSUxV?= =?utf-8?B?ai9GZUg0bllVUUlwRlVNNzRvRUR1T2JpY2pWYkJDNGFCT3NkM2NiSnlvOEJz?= =?utf-8?B?cTZMNVY1dGhQbHdSZS9rVjZDSlV1eHo3Sm1qdjZIK1lGTXl3N054czJRTURi?= =?utf-8?B?cGNwRFN5YzlDdG1ZL21TakpiWFQvQnN3Zm5LT01BWXRHcXpnSFBNUEhkOXpD?= =?utf-8?B?c1B4VGxmaVI1UUhLZ2tEcFV1emkwV21aR0VDOE1OODRMRFBQa05sRWRJVUR2?= =?utf-8?B?MVY1emt6RUc3NkI1bDhNRWU4ZExYMXQyVTE5Zk1QemdxQ2lZTFBNMjVCNCti?= =?utf-8?B?ZWlLTW8yMVo0NDhtUnUxUWo2MXNBRXhnSnhjd2xUOU5Xc3FOSDhLSnRZTjhM?= =?utf-8?B?S2xhazYwRUwveCtnRFg5bmN6L0lDaTFCYlVyeE5kOWdLUzdYUDNVa0hMWE52?= =?utf-8?B?RnhwYzZmMUpSMmx4RDJRZU02Qi9jVG82YnRjUVp4VXBZZ2M0YVg0dU5lWjlR?= =?utf-8?B?WXlXdElpQThueHZHcTUvUzE3cGlla3prdysyaU1tVmMza2dFLy9DTkVKNjQ0?= =?utf-8?B?NFVUUW1kK3VvdExYVk1jVGliWmd4TzkxSEpuTnFrb0pZMXhmMEZncDV0RENN?= =?utf-8?B?QWg1aHRJS1EvdlFtM0l5MzZDVHo1ekY1M2R4MDhsSTR6RVpMT01ZdytDNHVU?= =?utf-8?B?S3IxbXY4K3MrNjQ2ZENlYStGUUZkY1VnWjBNWiswM1pacFNLYVJTcVF6bGgv?= =?utf-8?B?MDkreWJYQmlIRk9jSWJkazdIOEI0anRTZWxmcDhodFJVT0hCbXRzb2xhYzNN?= =?utf-8?B?Rzc0ZlVzdUVHVGZ6VEg2S09zVGU3aC94MHlsOXZlZXlEZVN6YU9URVQxc0o1?= =?utf-8?B?Rm14ZFpZWTZtUVk2b1ZFamI1ZWp4QWplbXN5NjB1bUZ2c20wa20zSkhaMXJs?= =?utf-8?B?d0ovT0FtbUVNUCtzSGJaV0pPREZkTDM2OHJjVDJlY0FjSEZVZ0o0Sk5wU3ZC?= =?utf-8?B?TUpVL2tNTVV0UnRsek83anhXSFkwM29ydG9zTy8zdWhmVUpmenlZY0FSZjMz?= =?utf-8?B?enVLSTNKYnorNjZyMHdDTVBhTG5SenhlYUl6M2RBRVlRRVh5dHlmd1cwU05V?= =?utf-8?B?UUdxanUrNWdHWHlXTVh2SzJiWnJSalZLSnRzUVVHN3dKZmUvWkhzWVlGSm9Y?= =?utf-8?B?ODhXcEZwWjNrMlR4YWRGbFA1ZnFPRDZsV3VZQmVlTTRoT1hvdWtwdk9sVnZw?= =?utf-8?B?WWM5eDNLM1hGUWNuSkJZS1hsU3d3K3p5RnR3eDBSOFdNbWZpSE1jNFhkM0dC?= =?utf-8?B?N01IVm56eWF5K2QweDhmbmFza29VK05BVVFYYTN2aTdLZDZnZ1ZOL2xhVG51?= =?utf-8?B?bGRyamUvcnVVa1pKbHBBK01kMEFmTTNPQzJ3YlJLQ2w3UUxROUtvaFB6NGU4?= =?utf-8?B?d3RmeVNmdGV0aytlaVgram5vMFdxRWRod3h6dkxNVXFWcWlmVzQ4SFNock5s?= =?utf-8?B?YlU2K2ZZT1dnY3BsRVp1SUdDTnN5eXM5bGNnTCt1L1g3RWdySGhVL2U5TklK?= =?utf-8?B?ZzFHOEpTTDlmdlRzbVVUUTR2NFVoYlcyMzZ1Mk1TYVJJUVc0Z01YRzF2ellh?= =?utf-8?B?WEZaQnZ4NnpXRGJscmJTdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8102.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlR2MXRZdkZwMHduSEs2aHN3Vm81dXRWTlVCcWREMTFlYmg3UFlzNGFrMkZz?= =?utf-8?B?Z21ZMVpTRVVxdTRsRlpOWGpaMmp1RTFVa1FrS0NGREZIcDZCcjdxNmFmVFJx?= =?utf-8?B?eEdEL3V3QjJkWmtNanFVaFluMGlqVXlCRGkvV0pabWNidVkyclhjNlBQWmEy?= =?utf-8?B?SlYvQ1lFTXIvbFFmWUFnNHY5Z1gxQUZvLzRTMEdqRUZDRFpVaTNpNzN6QkRr?= =?utf-8?B?Yk53MDRSQkp1L3lyRXF2SUJBVWUwTjdTNDY3c1psdlh1L1Z0SlhsZXcxRkVC?= =?utf-8?B?YytHV1hrbGM2bDRNVE1BcXVKenVrRjBrdzRob2RPYTV1eFhKbWloa1JnczZB?= =?utf-8?B?akdvdmJEVWNpRDF6Wnc0K01NRGVKbUtzL3UxdjM5NWFEcEMrSGRiT0RsLzBY?= =?utf-8?B?L1RJdXIvbTFBMVplQmU4RVFjb1BpakM2b21CUjJkMndlTk9haGw3SjRQSklx?= =?utf-8?B?OHdpSmdqRUlLdFRUemdKLzBmTkxoQjZTTlZFSzZOS2NqTFRmdGprd0pIZ04z?= =?utf-8?B?b2lFQ0cySVhJYk8xK0poN1RTaEVJQmZoOUtrZnp4YmhzbitSSCs0aE55QjNl?= =?utf-8?B?ODBDVVVESW5KWC9kdngxNy9lTnBFT2lQMGJwL2JkbHFZL1RnUEMybmhYdkp6?= =?utf-8?B?bWFOdVM5cTliMFlxOGNmeTVnaXQwa1AvTFpzOVRXN3Vvc21LelZ1UzI3bFpD?= =?utf-8?B?dXRzWi8rOTNCR1M4ZVFmc0VPMUZ5bUJ5N3FyMnZwOG5iNXJtd0pUaGRjaE5C?= =?utf-8?B?N0p3OTJ5QjZrM08xMHlMVEdGMW5JSEJTS3QzSERRcXJsL2JLMjFrbExURG5h?= =?utf-8?B?N2VGMzRYTHRQVXlXS1FwWlJCV2Z1RS83cFo3RWJCSlNFNzRnUFdYcVFkUzZr?= =?utf-8?B?YVZrYWdrM3VDaWZ4TjdETXFHNE96K3A5aWhOT2psZFlKRHF0VXVJN094SnUw?= =?utf-8?B?VGRXb1hMS3FvM3QvQTdyT05nd1B5eFN2QXp0d0xhTGZyVitsY2d2TTZhdFF4?= =?utf-8?B?eXp0TVJJbkVjV2h0Qk1XUGdKK3Q1NkZFRUIvZ2dIZFArbVF4UnNlTFdhUnBK?= =?utf-8?B?aXdTNW5YdDZWcGd3bXRaMlkxUTJTbnJROG1rSisrOHJscCtDZkloR2kzVnEv?= =?utf-8?B?Y082MTBrempKZVJUcW9uU1RUQ1pnNWN1ZGtCMU1PMnhkc2VHd3N4OW93NVlN?= =?utf-8?B?LzhFMUZOVFNwTjc1VzdWNFB0Y1JMckNGdi9iZFlLa3VVT25Jd3RScCtqWDNQ?= =?utf-8?B?cjR2OHNCQlNaamZ0YTIzdUplVlduNmQ4SmNiNXFZcFVmOVRPS0YvOEl0R2tS?= =?utf-8?B?NkE4cnkrMVd4UDAwTW5GQjQ1OElUbGs1WW5wNmYrdnlmQ1JSSlNmZzVtb1gv?= =?utf-8?B?Z3ZoNUlSVXJGUG9GdDl5M1RyVW5CenduQllucGxrV2FoZjJYN2xNWFdEa1I1?= =?utf-8?B?K2c2YUJ5dEl6UDFkZEZudmIwTlN0T25xcHpwSDB4YTEzbDhTUTlXYnBSVnFk?= =?utf-8?B?bHBOTW02UWdid01oeHNyRk5obWdrSHRESGtOYWxrbWZvMlY3T2QyZGc4K1RZ?= =?utf-8?B?UGNpbkpIMDBnT0EvREZMLzZGcHFZWjc0UUFlMFBGQXNKQWtXV0JzWWk2S2tx?= =?utf-8?B?TGpkYUVkdlp3aHNRaDA2a3NhTVQ2VXFwU1lzUXlrSVFLVzhlVXFLUUc2Ri9Q?= =?utf-8?B?V2pzTlFaQmcwZTkwWStiVzlLVHhKWE1YaE5HcHJFY2NZOWlIamZ1WWptMWhJ?= =?utf-8?B?SW1HU1UxU1JFT01yL1kvQ2ZhM2dxYkR5ZWZiWUlaUDY5NmczL1RSK3NOMTl2?= =?utf-8?B?M21Vb01FRStlZVpnbkxhU3Uybm9DRnhlMmVZSHpEdHdsRHQ5YTdSNEd5Um1i?= =?utf-8?B?bllJcElwSTFURFA3Smd1Nko3dDA3MUViZ04vSUxLem91d0RSUWZSY2JLZDY1?= =?utf-8?B?L1RsRlI3NWVybmFyZWhYZ0Uyb29tQi9mSUdZc1FpRk92NnFWM1hQTXphNk53?= =?utf-8?B?VFY3T2I5UkZMZjFkaFQxOUV3bzBPNjNmZ0ZiTzZRbXN1T1JSa2lmNFYxd0kw?= =?utf-8?B?Tm1nMVloK3k0dVVIVkxxc3FLSlpCS2V4MXRNcjdUMU5LOXYxRlpNekxkVGtQ?= =?utf-8?B?ZzBPdGsrdW5lczVCais4Ukh2RTl4VlI1Z0FSMnR0VCtENXVQU3hMT0p1cE9u?= =?utf-8?B?MHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: db7f9c7b-2a50-4838-4e27-08dc9a65c2df X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2024 07:08:23.3032 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zkm96VTBZ+gF3ChZQ+qmD2KS6PbUs9bHe+gkVjj8oAvjhYdiEVOP1js66M61o9vRsIuHvfd0gFpHuwU7tJRqZkCPX5tfClASPpsvxmPAXgk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7330 X-OriginatorOrg: intel.com On 7/1/24 18:41, Petr Machata wrote: > A forgotten or buggy variable initialization can cause out-of-bounds access > to a register or other item array field. For an overflow, such access would > mangle adjacent parts of the register payload. For an underflow, due to all > variables being unsigned, the access would likely trample unrelated memory. > Since neither is correct, replace these accesses with accesses at the index > of 0, and warn about the issue. That is not correct either, but indeed better. > > Suggested-by: Ido Schimmel > Signed-off-by: Petr Machata > Reviewed-by: Ido Schimmel > --- > drivers/net/ethernet/mellanox/mlxsw/item.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/item.h b/drivers/net/ethernet/mellanox/mlxsw/item.h > index cfafbeb42586..9f7133735760 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/item.h > +++ b/drivers/net/ethernet/mellanox/mlxsw/item.h > @@ -218,6 +218,8 @@ __mlxsw_item_bit_array_offset(const struct mlxsw_item *item, > } > > max_index = (item->size.bytes << 3) / item->element_size - 1; > + if (WARN_ON(index > max_index)) > + index = 0; you have BUG*() calls just above those lines :( anyway, WARN_ON_ONCE(), and perhaps you need to print some additional data to finally fix this? > be_index = max_index - index; > offset = be_index * item->element_size >> 3; > in_byte_index = index % (BITS_PER_BYTE / item->element_size);