Re: [PATCH net-next 1/3] net/sched: Introduce action ct

[Davide Caratti <dcaratti@redhat.com>]

On Thu, 2019-06-13 at 12:16 +0200, Davide Caratti wrote:
> hello Paul!
> 
> On Tue, 2019-06-11 at 16:28 +0300, Paul Blakey wrote:
> 
> > +#endif /* __NET_TC_CT_H */
> > diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
> > index a93680f..c5264d7 100644
> > --- a/include/uapi/linux/pkt_cls.h
> > +++ b/include/uapi/linux/pkt_cls.h
> > @@ -83,6 +83,7 @@ enum {
> >  #define TCA_ACT_SIMP 22
> >  #define TCA_ACT_IFE 25
> >  #define TCA_ACT_SAMPLE 26
> > +#define TCA_ACT_CT 27
> 
> ^^  I think you can't use 27 (act_ctinfo forgot to explicitly define it),
> or the uAPI will break. See below:

[...]

Nevermind, I just read the comment above the definition of TCA_ACT_GACT.
> > 
> so, I think you should use 28. And I will send a patch for net-next now
> that adds the missing define for TCA_ID_CTINFO. Ok?

we don't need to patch pkt_cls.h. Just avoid 

#define TCA_ACT_CT 27 

and the assignment in the enum, that should be sufficient.
-- 
davide