From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC4EEC31E45 for ; Thu, 13 Jun 2019 15:32:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B7FB206BB for ; Thu, 13 Jun 2019 15:32:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728499AbfFMPcU (ORCPT ); Thu, 13 Jun 2019 11:32:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52170 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728486AbfFMKtc (ORCPT ); Thu, 13 Jun 2019 06:49:32 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0DD383003E4F; Thu, 13 Jun 2019 10:49:22 +0000 (UTC) Received: from localhost.localdomain (unknown [10.32.181.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4AA34506; Thu, 13 Jun 2019 10:49:16 +0000 (UTC) Message-ID: <7ad9dd803e3d961fef3ceaf77215f27e02b04981.camel@redhat.com> Subject: Re: [PATCH net-next 1/3] net/sched: Introduce action ct From: Davide Caratti To: Paul Blakey , Jiri Pirko , Roi Dayan , Yossi Kuperman , Oz Shlomo , Marcelo Ricardo Leitner , netdev@vger.kernel.org, David Miller , Aaron Conole , Zhike Wang Cc: Justin Pettit , John Hurley , Rony Efraim , nst-kernel@redhat.com, Simon Horman In-Reply-To: References: <1560259713-25603-1-git-send-email-paulb@mellanox.com> <1560259713-25603-2-git-send-email-paulb@mellanox.com> Organization: red hat Content-Type: text/plain; charset="UTF-8" Date: Thu, 13 Jun 2019 12:49:15 +0200 Mime-Version: 1.0 User-Agent: Evolution 3.30.3 (3.30.3-1.fc29) Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 13 Jun 2019 10:49:30 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2019-06-13 at 12:16 +0200, Davide Caratti wrote: > hello Paul! > > On Tue, 2019-06-11 at 16:28 +0300, Paul Blakey wrote: > > > +#endif /* __NET_TC_CT_H */ > > diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h > > index a93680f..c5264d7 100644 > > --- a/include/uapi/linux/pkt_cls.h > > +++ b/include/uapi/linux/pkt_cls.h > > @@ -83,6 +83,7 @@ enum { > > #define TCA_ACT_SIMP 22 > > #define TCA_ACT_IFE 25 > > #define TCA_ACT_SAMPLE 26 > > +#define TCA_ACT_CT 27 > > ^^ I think you can't use 27 (act_ctinfo forgot to explicitly define it), > or the uAPI will break. See below: [...] Nevermind, I just read the comment above the definition of TCA_ACT_GACT. > > > so, I think you should use 28. And I will send a patch for net-next now > that adds the missing define for TCA_ID_CTINFO. Ok? we don't need to patch pkt_cls.h. Just avoid #define TCA_ACT_CT 27 and the assignment in the enum, that should be sufficient. -- davide