From: David Ahern <dsahern@kernel.org>
To: Richard Gobert <richardbgobert@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, willemdebruijn.kernel@gmail.com,
tom@herbertland.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gal@nvidia.com
Subject: Re: [PATCH v3 1/1] net: gro: fix misuse of CB in udp socket lookup
Date: Fri, 28 Jul 2023 15:21:40 -0600 [thread overview]
Message-ID: <7adc43f3-725d-84df-065d-7d77d03327f6@kernel.org> (raw)
In-Reply-To: <20230727153353.GA32089@debian>
On 7/27/23 9:33 AM, Richard Gobert wrote:
> This patch fixes a misuse of IP{6}CB(skb) in GRO, while calling to
> `udp6_lib_lookup2` when handling udp tunnels. `udp6_lib_lookup2` fetch the
> device from CB. The fix changes it to fetch the device from `skb->dev`.
> l3mdev case requires special attention since it has a master and a slave
> device.
>
> Fixes: a6024562ffd7 ("udp: Add GRO functions to UDP socket")
> Reported-by: Gal Pressman <gal@nvidia.com>
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
> ---
> include/net/gro.h | 43 ++++++++++++++++++++++++++++++++++++++++++
> net/ipv4/udp.c | 8 ++++++--
> net/ipv4/udp_offload.c | 7 +++++--
> net/ipv6/udp.c | 8 ++++++--
> net/ipv6/udp_offload.c | 7 +++++--
> 5 files changed, 65 insertions(+), 8 deletions(-)
>
I still think the text in the cover letter should be in this commit message.
Code wise, it looks ok to me:
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-07-28 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 15:25 [PATCH v3 0/1] net: gro: fix misuse of CB in udp socket lookup Richard Gobert
2023-07-27 15:33 ` [PATCH v3 1/1] " Richard Gobert
2023-07-28 21:21 ` David Ahern [this message]
2023-07-29 17:20 ` [PATCH v3 0/1] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7adc43f3-725d-84df-065d-7d77d03327f6@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=tom@herbertland.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).