From: Dan Carpenter <dan.carpenter@linaro.org>
To: Meghana Malladi <m-malladi@ti.com>
Cc: netdev@vger.kernel.org
Subject: [bug report] net: ti: icss-iep: Add pwidth configuration for perout signal
Date: Wed, 12 Mar 2025 11:30:49 +0300 [thread overview]
Message-ID: <7b1c7c36-363a-4085-b26c-4f210bee1df6@stanley.mountain> (raw)
Hello Meghana Malladi,
Commit e5b456a14215 ("net: ti: icss-iep: Add pwidth configuration for
perout signal") from Mar 4, 2025 (linux-next), leads to the following
Smatch static checker warning:
drivers/net/ethernet/ti/icssg/icss_iep.c:825 icss_iep_exit()
error: NULL dereference inside function icss_iep_perout_enable()
drivers/net/ethernet/ti/icssg/icss_iep.c
815 {
816 if (iep->ptp_clock) {
817 ptp_clock_unregister(iep->ptp_clock);
818 iep->ptp_clock = NULL;
819 }
820 icss_iep_disable(iep);
821
822 if (iep->pps_enabled)
823 icss_iep_pps_enable(iep, false);
824 else if (iep->perout_enabled)
--> 825 icss_iep_perout_enable(iep, NULL, false);
^^^^
Originally icss_iep_perout_enable() just returned -ENOTSUPP but now it
needs a valid "req" pointer.
826
827 return 0;
828 }
regards,
dan carpenter
next reply other threads:[~2025-03-12 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 8:30 Dan Carpenter [this message]
2025-03-12 10:04 ` [EXTERNAL] [bug report] net: ti: icss-iep: Add pwidth configuration for perout signal Malladi, Meghana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b1c7c36-363a-4085-b26c-4f210bee1df6@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox