From: Krzysztof Kozlowski <krzk@kernel.org>
To: G <c3bersexnews@gmail.com>, Networking <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
David Heidelberg <david@ixit.cz>
Subject: Re: [Security] NFC: digital: peer-controlled stack overflow in digital_in_recv_sensf_res() (sibling to CVE-2026-31622)
Date: Tue, 28 Apr 2026 14:34:08 +0200 [thread overview]
Message-ID: <7b68e0c4-ac9d-43c1-af62-f306c4cdc751@kernel.org> (raw)
In-Reply-To: <1499e17a-43bd-4811-bfcc-f5334a62c75f@kernel.org>
On 28/04/2026 14:21, Krzysztof Kozlowski wrote:
>> --- a/net/nfc/digital_technology.c
>> +++ b/net/nfc/digital_technology.c
>> @@ -762,7 +762,12 @@ static void digital_in_recv_sensf_res(struct
>> nfc_digital_dev *ddev, void *arg,
>> if (resp->len < DIGITAL_SENSF_RES_MIN_LENGTH) {
>> rc = -EIO;
>> goto exit;
>> }
>>
>> + if (resp->len > NFC_SENSF_RES_MAXSIZE) {
>> + rc = -EIO;
>> + goto exit;
>> + }
>> +
>> if (!DIGITAL_DRV_CAPS_IN_CRC(ddev)) {
>> rc = digital_skb_check_crc_f(resp);
>>
>> Signed-off-by: <your name and email here>
>
> Do you want to send a proper Linux patch for it with proper authorship
> (see submitting patches)?
FWIW, the code is indeed missing the check and the fix looks good.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-28 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFqytU96TsqxZpcEtotFG2bP3kr=zwDQz94MonKYmSSL12rbWw@mail.gmail.com>
2026-04-28 12:21 ` [Security] NFC: digital: peer-controlled stack overflow in digital_in_recv_sensf_res() (sibling to CVE-2026-31622) Krzysztof Kozlowski
2026-04-28 12:34 ` Krzysztof Kozlowski [this message]
[not found] ` <CAFqytU9LOz6Pz=ja6N6zBLRPejk2KnyNtaSV1wcNfeGS0guMgA@mail.gmail.com>
2026-04-30 6:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b68e0c4-ac9d-43c1-af62-f306c4cdc751@kernel.org \
--to=krzk@kernel.org \
--cc=c3bersexnews@gmail.com \
--cc=david@ixit.cz \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox