netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yanteng Si <si.yanteng@linux.dev>
To: Furong Xu <0x1207@gmail.com>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>,
	Joe Damato <jdamato@fastly.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	xfr@outlook.com
Subject: Re: [PATCH net-next v3 2/4] net: stmmac: Set page_pool_params.max_len to a precise size
Date: Wed, 15 Jan 2025 18:07:32 +0800	[thread overview]
Message-ID: <7b6acdc1-5151-427a-ac84-a6cb666f53ca@linux.dev> (raw)
In-Reply-To: <538f87c8bdd0ba9e2b9cb5cd0e2964511c001890.1736910454.git.0x1207@gmail.com>

在 2025/1/15 11:27, Furong Xu 写道:
> DMA engine will always write no more than dma_buf_sz bytes of a received
> frame into a page buffer, the remaining spaces are unused or used by CPU
> exclusively.
> Setting page_pool_params.max_len to almost the full size of page(s) helps
> nothing more, but wastes more CPU cycles on cache maintenance.
> 
> For a standard MTU of 1500, then dma_buf_sz is assigned to 1536, and this
> patch brings ~16.9% driver performance improvement in a TCP RX
> throughput test with iPerf tool on a single isolated Cortex-A65 CPU
> core, from 2.43 Gbits/sec increased to 2.84 Gbits/sec.
> 
> Signed-off-by: Furong Xu <0x1207@gmail.com>
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: Yanteng Si <si.yanteng@linux.dev>

Thanks,
Yanteng

> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>   drivers/net/ethernet/stmicro/stmmac/stmmac_xdp.h  | 1 -
>   2 files changed, 1 insertion(+), 2 deletions(-)



  reply	other threads:[~2025-01-15 10:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15  3:27 [PATCH net-next v3 0/4] net: stmmac: RX performance improvement Furong Xu
2025-01-15  3:27 ` [PATCH net-next v3 1/4] net: stmmac: Switch to zero-copy in non-XDP RX path Furong Xu
2025-01-15 16:58   ` Larysa Zaremba
2025-01-16  2:05   ` Yanteng Si
2025-01-23 14:06   ` Jon Hunter
2025-01-23 16:35     ` Furong Xu
2025-01-23 19:53       ` Brad Griffis
2025-01-23 21:48         ` Andrew Lunn
2025-01-24  2:42           ` Furong Xu
2025-01-24 13:15             ` Thierry Reding
2025-01-28 20:04               ` Lucas Stach
2025-01-25 10:20             ` Ido Schimmel
2025-01-25 14:43               ` Furong Xu
2025-01-26  8:41                 ` Ido Schimmel
2025-01-26 10:37                   ` Furong Xu
2025-01-26 11:35                     ` Ido Schimmel
2025-01-26 12:56                       ` Furong Xu
2025-01-25 15:03               ` Furong Xu
2025-01-25 19:08                 ` Andrew Lunn
2025-01-26  2:39                   ` Furong Xu
2025-01-27 13:28                 ` Thierry Reding
2025-01-29 14:51                   ` Jon Hunter
2025-02-07  9:07                     ` Furong Xu
2025-02-07 13:42                       ` Jon Hunter
2025-01-24  1:53         ` Furong Xu
2025-01-24 15:14           ` Andrew Lunn
2025-01-15  3:27 ` [PATCH net-next v3 2/4] net: stmmac: Set page_pool_params.max_len to a precise size Furong Xu
2025-01-15 10:07   ` Yanteng Si [this message]
2025-01-15  3:27 ` [PATCH net-next v3 3/4] net: stmmac: Optimize cache prefetch in RX path Furong Xu
2025-01-15 16:24   ` Yanteng Si
2025-01-15  3:27 ` [PATCH net-next v3 4/4] net: stmmac: Convert prefetch() to net_prefetch() for received frames Furong Xu
2025-01-15 16:33   ` Yanteng Si
2025-01-15 16:35   ` Larysa Zaremba
2025-01-15 17:35   ` Joe Damato
2025-01-16 11:40 ` [PATCH net-next v3 0/4] net: stmmac: RX performance improvement patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b6acdc1-5151-427a-ac84-a6cb666f53ca@linux.dev \
    --to=si.yanteng@linux.dev \
    --cc=0x1207@gmail.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jdamato@fastly.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xfr@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).