From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BCC6481A0; Sun, 17 Dec 2023 19:16:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ta3r/nvd" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2cc4029dc6eso27073831fa.1; Sun, 17 Dec 2023 11:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702840574; x=1703445374; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=yEgP8jIJVAEUyj5VeqhD7WNWwleYce7HTymoGIdGF9o=; b=Ta3r/nvdVrb7sSJQTrJxs5zkOT1CsNUmjgX4SFqYIW/BRvppaDBQSE4Wj6mSArjc8c 8EuNquaEXNuhGzzm/nNLg1YIOwFbi4iildarbgi1ljuJhfh1yW9wCy1vfgtkGSDgNo/s PjK0aD9RJjnRP1Y4ysAMRCaAeARtbZXzivpIR+1RLrdxeBh1ket2nN9jNQWs7RBmaidy Xe0xIOWY/gCozLnACnRnqz6zPwLDRUWQPowGoBiVxLUH6TMbCia6E1AmZ51MyvLO7+FE xif95+9wgIxLNnvBqm1GNXteO7v//S9dwR8C2dkv8y5uhAZQ3SqWuOx7oDZwvNkiuKkb jdfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702840574; x=1703445374; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yEgP8jIJVAEUyj5VeqhD7WNWwleYce7HTymoGIdGF9o=; b=Tz9o7tOJCIdss6BJ1XEcCMsUb7TJtqLWqcdUMQR4Dp6MMDApXh7zMPq9YH5EPkJZpk NgrpFrJjork7FkfMUEpQ80+WoreKxrykMJZ+qWWyfewHsR75OyFSkIFl6mFkM/rs89Pb RvuNkuO/rc7cgBxuCnr/lIguOhOuFkXwnS5DaSNzGIRWDql5y4d1w1u0FVcmc3JhxCFM qxaA0mHLfhHBQuXkJphbsVAXaV91AKPz7EYgGJPfZ8PTw59L9Y0GQXnWLgCJDf6FzMib Mr8/JlOeLzeI3YU+XnEzsdxvvx/srMJ/meyyVbbUIo2nEWLqXJEskw0Zyf7wacJquxWo mR5Q== X-Gm-Message-State: AOJu0YzqrI2eUziPw962St8g1sU/R8RQBa2M6YPMzhpfKS4+DrRvC+Ns j6aNq3CJap2Wpb9kwt3IlXnOhTe7zdw= X-Google-Smtp-Source: AGHT+IF2/mE2xKWlzjaf5tcwQmmdUPdf5ylsE16VTN8t7vCGCYf9Cuk2C+7Edzfg0frx8Qv/UlUgDg== X-Received: by 2002:a2e:9787:0:b0:2ca:d14:96cf with SMTP id y7-20020a2e9787000000b002ca0d1496cfmr6452714lji.48.1702840573999; Sun, 17 Dec 2023 11:16:13 -0800 (PST) Received: from ?IPV6:2a01:c22:6e42:9000:b4eb:1338:e451:9de3? (dynamic-2a01-0c22-6e42-9000-b4eb-1338-e451-9de3.c22.pool.telefonica.de. [2a01:c22:6e42:9000:b4eb:1338:e451:9de3]) by smtp.googlemail.com with ESMTPSA id ds12-20020a0564021ccc00b00552a6a19ed0sm2779409edb.9.2023.12.17.11.16.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Dec 2023 11:16:12 -0800 (PST) Message-ID: <7b6cf0fb-4c77-4088-b87b-5649cfaa697e@gmail.com> Date: Sun, 17 Dec 2023 20:16:11 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESUBMIT] leds: trigger: netdev: add core support for hw not supporting fallback to LED sw control Content-Language: en-US From: Heiner Kallweit To: Pavel Machek , Lee Jones Cc: "linux-leds@vger.kernel.org" , "netdev@vger.kernel.org" , Andrew Lunn References: <3fd5184c-3641-4b0b-b59a-f489ec69a6cd@gmail.com> Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: <3fd5184c-3641-4b0b-b59a-f489ec69a6cd@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17.12.2023 19:46, Heiner Kallweit wrote: > If hw doesn't support sw control of the LED and we switch to a mode > not supported by hw, currently we get lots of errors because neither > brigthness_set() nor brithness_set_blocking() is set. > Deal with this by not falling back to sw control, and return > -EOPNOTSUPP to the user. Note that we still store the new mode. > This is needed in case an intermediate unsupported mode is necessary > to switch from one supported mode to another. > > Add a comment explaining how a driver for such hw is supposed to behave. > > Signed-off-by: Heiner Kallweit > --- For whatever reason this patch (original version and resubmit) doesn't show up on linux-leds patchwork. In netdev patchwork it's visible.