From: Alexei Starovoitov <ast@fb.com>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Josef Bacik <josef@toxicpanda.com>
Cc: <rostedt@goodmis.org>, <mingo@redhat.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ast@kernel.org>, <kernel-team@fb.com>, <daniel@iogearbox.net>,
<linux-btrfs@vger.kernel.org>, <darrick.wong@oracle.com>,
Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH v10 1/5] add infrastructure for tagging functions as error injectable
Date: Tue, 19 Dec 2017 18:14:17 -0800 [thread overview]
Message-ID: <7b73cbfa-959f-2efe-8a7c-f9d0b0c2ccaa@fb.com> (raw)
In-Reply-To: <20171219152925.5789309c6c4d27807d42f11c@kernel.org>
On 12/18/17 10:29 PM, Masami Hiramatsu wrote:
>>
>> +#if defined(__KERNEL__) && !defined(__ASSEMBLY__)
>> +#ifdef CONFIG_BPF_KPROBE_OVERRIDE
>
> BTW, CONFIG_BPF_KPROBE_OVERRIDE is also confusable name.
> Since this feature override a function to just return with
> some return value (as far as I understand, or would you
> also plan to modify execution path inside a function?),
> I think it should be better CONFIG_BPF_FUNCTION_OVERRIDE or
> CONFIG_BPF_EXECUTION_OVERRIDE.
I don't think such renaming makes sense.
The feature is overriding kprobe by changing how kprobe returns.
It doesn't override BPF_FUNCTION or BPF_EXECUTION.
The kernel enters and exists bpf program as normal.
> Indeed, BPF is based on kprobes, but it seems you are limiting it
> with ftrace (function-call trace) (I'm not sure the reason why),
> so using "kprobes" for this feature seems strange for me.
do you have an idea how kprobe override can happen when kprobe
placed in the middle of the function?
Please make your suggestion as patches based on top of bpf-next.
Thanks
next prev parent reply other threads:[~2017-12-20 2:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 19:12 [PATCH v10 0/5] Add the ability to do BPF directed error injection Josef Bacik
2017-12-15 19:12 ` [PATCH v10 1/5] add infrastructure for tagging functions as error injectable Josef Bacik
2017-12-18 9:11 ` Masami Hiramatsu
2017-12-19 6:29 ` Masami Hiramatsu
2017-12-20 2:14 ` Alexei Starovoitov [this message]
2017-12-20 7:13 ` Masami Hiramatsu
2017-12-20 10:09 ` Daniel Borkmann
2017-12-20 17:22 ` Alexei Starovoitov
2017-12-20 11:00 ` Masami Hiramatsu
2017-12-20 17:33 ` Alexei Starovoitov
2017-12-15 19:12 ` [PATCH v10 2/5] btrfs: make open_ctree " Josef Bacik
2017-12-15 19:12 ` [PATCH v10 3/5] bpf: add a bpf_override_function helper Josef Bacik
2017-12-15 20:34 ` Alexei Starovoitov
2017-12-15 20:53 ` Daniel Borkmann
2017-12-18 9:51 ` Masami Hiramatsu
2017-12-18 15:09 ` Daniel Borkmann
2017-12-19 6:38 ` Masami Hiramatsu
2017-12-15 19:12 ` [PATCH v10 4/5] samples/bpf: add a test for bpf_override_return Josef Bacik
2017-12-15 19:12 ` [PATCH v10 5/5] btrfs: allow us to inject errors at io_ctl_init Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b73cbfa-959f-2efe-8a7c-f9d0b0c2ccaa@fb.com \
--to=ast@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=jbacik@fb.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).