From: Tom Rix <trix@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: pshelar@ovn.org, kuba@kernel.org, natechancellor@gmail.com,
ndesaulniers@google.com, netdev@vger.kernel.org,
dev@openvswitch.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters
Date: Wed, 2 Sep 2020 11:40:10 -0700 [thread overview]
Message-ID: <7b82468b-bc67-df62-1816-1f510888fc39@redhat.com> (raw)
In-Reply-To: <20200901.131111.186993526997490086.davem@davemloft.net>
On 9/1/20 1:11 PM, David Miller wrote:
> From: trix@redhat.com
> Date: Sun, 30 Aug 2020 14:26:30 -0700
>
>> Passing unused parameters is a waste.
> Poorly predicted branches are an even bigger waste.
>
> I'm not a big fan of this change and others have asked for performance
> analysis to be performed.
>
> So I'm not applying this as-is, sorry.
no worries.
I think these functions need a larger working over so the stats collecting are not in the core functions.
Thanks for giving it a look,
Tom
>
> It's also not great to see that CLANG can't make use of the caller's
> __always_unused directive to guide these warnings.
prev parent reply other threads:[~2020-09-02 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 21:26 [PATCH v2] net: openvswitch: pass NULL for unused parameters trix
2020-08-31 7:50 ` Eelco Chaudron
2020-08-31 7:56 ` Eelco Chaudron
2020-09-01 20:11 ` David Miller
2020-09-02 18:40 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b82468b-bc67-df62-1816-1f510888fc39@redhat.com \
--to=trix@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).