From: Denis Kirjanov <dkirjanov@suse.de>
To: "Александра Дюпина" <adiupina@astralinux.ru>,
"Jakub Kicinski" <kuba@kernel.org>,
"Zhao Qiang" <qiang.zhao@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH v3] fsl_ucc_hdlc: process the result of hold_open()
Date: Fri, 1 Sep 2023 14:05:59 +0300 [thread overview]
Message-ID: <7b8be7bd-baf2-15c0-2a0c-ddf64839a451@suse.de> (raw)
In-Reply-To: <977826f0-3289-53bd-b3f6-90977a4e0ca0@astralinux.ru>
On 9/1/23 13:48, Александра Дюпина wrote:
> Thanks for the review!
>
> 28.08.2023 22:38, Jakub Kicinski пишет:
>> Don't you have to undo all the things done prior to hdlc_open()?
> Yes, it looks like I really need to undo everything that was done before hdlc_open().
> But the question arose - would it be enough to call the uhdlc_close(dev) function?
looks like it is.
> In addition, it seems to me and my colleagues that a call to hdlc_close(dev) should be added to the uhdlc_close() function, similar to the
yes, take a look at the comment for hdlc_close()
following functions:
> 1. drivers/net/wan/n2.c (n2_close function)
> 2. drivers/net/wan/pc300too.c (pc300_close function)
> 3. drivers/net/wan/pci200syn.c (pci200_close function)
> 4. drivers/net/wan/wanxl.c (wanxl_close function)
> Tell me, please, are we wrong?
>
next prev parent reply other threads:[~2023-09-01 11:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 14:31 [PATCH] fsl_ucc_hdlc: add a check of the return value from hdlc_open Alexandra Diupina
2023-08-26 6:32 ` Christophe Leroy
2023-08-28 8:27 ` [PATCH v2] " Alexandra Diupina
2023-08-28 8:37 ` Christophe Leroy
2023-08-28 12:12 ` [PATCH v3] fsl_ucc_hdlc: process the result of hold_open() Alexandra Diupina
2023-08-28 13:11 ` Christophe Leroy
2023-08-28 19:38 ` Jakub Kicinski
2023-09-01 10:48 ` Александра Дюпина
2023-09-01 11:05 ` Denis Kirjanov [this message]
2023-09-04 12:31 ` [PATCH v4] drivers/net: process the result of hdlc_open() and add call of hdlc_close() in uhdlc_close() Alexandra Diupina
2023-09-04 17:03 ` Christophe Leroy
2023-09-04 17:04 ` Christophe Leroy
2023-09-05 10:46 ` Paolo Abeni
2023-09-19 14:25 ` [PATCH v5] " Alexandra Diupina
2023-09-22 7:09 ` Christophe Leroy
2023-09-22 7:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b8be7bd-baf2-15c0-2a0c-ddf64839a451@suse.de \
--to=dkirjanov@suse.de \
--cc=adiupina@astralinux.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiang.zhao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).