From: Wenjia Zhang <wenjia@linux.ibm.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
kgraul@linux.ibm.com, jaka@linux.ibm.com, kuniyu@amazon.com,
linux-s390@vger.kernel.org
Subject: Re: [PATCH net-next 08/11] net: add missing includes of linux/splice.h
Date: Fri, 27 Jan 2023 13:35:06 +0100 [thread overview]
Message-ID: <7b971e79-f301-e2fb-7cfe-1a3062ccc0f5@linux.ibm.com> (raw)
In-Reply-To: <20230126071424.1250056-9-kuba@kernel.org>
On 26.01.23 08:14, Jakub Kicinski wrote:
> Number of files depend on linux/splice.h getting included
> by linux/skbuff.h which soon will no longer be the case.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kgraul@linux.ibm.com
> CC: wenjia@linux.ibm.com
> CC: jaka@linux.ibm.com
> CC: kuniyu@amazon.com
> CC: linux-s390@vger.kernel.org
> ---
> net/smc/af_smc.c | 1 +
> net/smc/smc_rx.c | 1 +
> net/unix/af_unix.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 036532cf39aa..1c0fe9ba5358 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -27,6 +27,7 @@
> #include <linux/if_vlan.h>
> #include <linux/rcupdate_wait.h>
> #include <linux/ctype.h>
> +#include <linux/splice.h>
>
> #include <net/sock.h>
> #include <net/tcp.h>
> diff --git a/net/smc/smc_rx.c b/net/smc/smc_rx.c
> index 0a6e615f000c..4380d32f5a5f 100644
> --- a/net/smc/smc_rx.c
> +++ b/net/smc/smc_rx.c
> @@ -13,6 +13,7 @@
> #include <linux/net.h>
> #include <linux/rcupdate.h>
> #include <linux/sched/signal.h>
> +#include <linux/splice.h>
>
Thank you, Jakub!
Acked-by: Wenjia Zhang <wenjia@linux.ibm.com>
> #include <net/sock.h>
> #include <trace/events/sock.h>
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index 009616fa0256..0be25e712c28 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -112,6 +112,7 @@
> #include <linux/mount.h>
> #include <net/checksum.h>
> #include <linux/security.h>
> +#include <linux/splice.h>
> #include <linux/freezer.h>
> #include <linux/file.h>
> #include <linux/btf_ids.h>
next prev parent reply other threads:[~2023-01-27 12:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 7:14 [PATCH net-next 00/11] net: skbuff: clean up unnecessary includes Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 01/11] net: add missing includes of linux/net.h Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 02/11] net: skbuff: drop the linux/net.h include Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 03/11] net: checksum: drop the linux/uaccess.h include Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 04/11] net: skbuff: drop the linux/textsearch.h include Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 05/11] net: add missing includes of linux/sched/clock.h Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 06/11] net: skbuff: drop the linux/sched/clock.h include Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 07/11] net: skbuff: drop the linux/sched.h include Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 08/11] net: add missing includes of linux/splice.h Jakub Kicinski
2023-01-27 12:35 ` Wenjia Zhang [this message]
2023-01-26 7:14 ` [PATCH net-next 09/11] net: skbuff: drop the linux/splice.h include Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 10/11] net: skbuff: drop the linux/hrtimer.h include Jakub Kicinski
2023-01-26 7:14 ` [PATCH net-next 11/11] net: remove unnecessary includes from net/flow.h Jakub Kicinski
2023-01-27 12:10 ` [PATCH net-next 00/11] net: skbuff: clean up unnecessary includes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b971e79-f301-e2fb-7cfe-1a3062ccc0f5@linux.ibm.com \
--to=wenjia@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).