From: David Ahern <dsahern@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH net 2/2] selftests: icmp_redirect: IPv6 PMTU info should be cleared after redirect
Date: Wed, 7 Jul 2021 08:51:22 -0600 [thread overview]
Message-ID: <7bc07872-adde-f81b-313f-59468e37c19d@gmail.com> (raw)
In-Reply-To: <20210707081530.1107289-3-liuhangbin@gmail.com>
On 7/7/21 2:15 AM, Hangbin Liu wrote:
> After redirecting, it's already a new path. So the old PMTU info should
> be cleared. The IPv6 test "mtu exception plus redirect" should only
> has redirect info without old PMTU.
>
> The IPv4 test can not be changed because of legacy.
>
> Fixes: ec8105352869 ("selftests: Add redirect tests")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> tools/testing/selftests/net/icmp_redirect.sh | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/icmp_redirect.sh b/tools/testing/selftests/net/icmp_redirect.sh
> index 3a111ac1edc3..ecbf57f264ed 100755
> --- a/tools/testing/selftests/net/icmp_redirect.sh
> +++ b/tools/testing/selftests/net/icmp_redirect.sh
> @@ -313,9 +313,10 @@ check_exception()
> fi
> log_test $? 0 "IPv4: ${desc}"
>
> - if [ "$with_redirect" = "yes" ]; then
> + # No PMTU info for test "redirect" and "mtu exception plus redirect"
> + if [ "$with_redirect" = "yes" ] && [ "$desc" != "redirect exception plus mtu" ]; then
> ip -netns h1 -6 ro get ${H1_VRF_ARG} ${H2_N2_IP6} | \
> - grep -q "${H2_N2_IP6} .*via ${R2_LLADDR} dev br0.*${mtu}"
> + grep -v "mtu" | grep -q "${H2_N2_IP6} .*via ${R2_LLADDR} dev br0"
> elif [ -n "${mtu}" ]; then
> ip -netns h1 -6 ro get ${H1_VRF_ARG} ${H2_N2_IP6} | \
> grep -q "${mtu}"
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2021-07-07 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 8:15 [PATCH net 0/2] Fix selftests icmp_redirect.sh failures Hangbin Liu
2021-07-07 8:15 ` [PATCH net 1/2] selftests: icmp_redirect: remove from checking for IPv6 route get Hangbin Liu
2021-07-07 14:49 ` David Ahern
2021-07-07 8:15 ` [PATCH net 2/2] selftests: icmp_redirect: IPv6 PMTU info should be cleared after redirect Hangbin Liu
2021-07-07 14:51 ` David Ahern [this message]
2021-07-07 20:51 ` [PATCH net 0/2] Fix selftests icmp_redirect.sh failures patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bc07872-adde-f81b-313f-59468e37c19d@gmail.com \
--to=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).