RE: [PATCH net-next 8/8] net: phy: use '__packed' instead of '__attribute__((__packed__))'

[David Laight <David.Laight@ACULAB.COM>]

From: Weihang Li
> Sent: 11 June 2021 07:37
> 
> Prefer __packed over __attribute__((__packed__)).
> 
> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
> Signed-off-by: Weihang Li <liweihang@huawei.com>
> ---
>  drivers/net/phy/mscc/mscc_ptp.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/mscc/mscc_ptp.h b/drivers/net/phy/mscc/mscc_ptp.h
> index da34653..01f78b4 100644
...
>  /* Represents an entry in the timestamping FIFO */
>  struct vsc85xx_ts_fifo {
>  	u32 ns;
>  	u64 secs:48;
>  	u8 sig[16];
> -} __attribute__((__packed__));
> +} __packed;

Hmmmm I'd take some convincing that 'u64 secs:48' is anything
other than 'implementation defined'.
So using it to map a hardware structure seems wrong.

If this does map a hardware structure it ought to have
'endianness' annotations.
If it doesn't then why the bitfield and why packed?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)