From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
To: netdev@vger.kernel.org
Cc: wimax@linuxwimax.org, greg@kroah.com
Subject: [PATCH 2/3] wimax: fix kconfig interactions with rfkill and input layers
Date: Tue, 6 Jan 2009 23:58:21 -0800 [thread overview]
Message-ID: <7c2fff491400cdec32b405fba1f2ead93ca40901.1231314782.git.inaky@linux.intel.com> (raw)
In-Reply-To: <cover.1231314782.git.inaky@linux.intel.com>
WiMAX can work without RFKILL, but it was missing a check to make sure
RFKILL is not being made a module with wimax compiled into the
kernel. This caused failed builds in s390, where CONFIG_INPUT is
always off.
When RFKILL is enabled, the code uses the input layer to report
hardware switch changes; thus, if RFKILL is enabled, INPUT has to be
too. It also needs to display some message when INPUT is disabled that
explains why WiMAX is not selectable.
(issues found by Randy Dunlap in the linux-next tree).
Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
---
net/wimax/Kconfig | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/net/wimax/Kconfig b/net/wimax/Kconfig
index 0bdbb69..18495cd 100644
--- a/net/wimax/Kconfig
+++ b/net/wimax/Kconfig
@@ -1,9 +1,23 @@
#
# WiMAX LAN device configuration
#
+# Note the ugly 'depends on' on WIMAX: that disallows RFKILL to be a
+# module if WIMAX is to be linked in. The WiMAX code is done in such a
+# way that it doesn't require and explicit dependency on RFKILL in
+# case an embedded system wants to rip it out.
+#
+# As well, enablement of the RFKILL code means we need the INPUT layer
+# support to inject events coming from hw rfkill switches. That
+# dependency could be killed if input.h provided appropiate means to
+# work when input is disabled.
+
+comment "WiMAX Wireless Broadband support requires CONFIG_INPUT enabled"
+ depends on INPUT = n && RFKILL != n
menuconfig WIMAX
tristate "WiMAX Wireless Broadband support"
+ depends on (y && RFKILL != m) || m
+ depends on (INPUT && RFKILL != n) || RFKILL = n
help
Select to configure support for devices that provide
--
1.5.6.5
next prev parent reply other threads:[~2009-01-07 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 7:58 [PATCH 0/3] wimax: Kbuild / rfkill-build fixes Inaky Perez-Gonzalez
2009-01-07 7:58 ` [PATCH 1/3] wimax: fix '#ifdef CONFIG_BUG' layout to avoid warning Inaky Perez-Gonzalez
2009-01-07 10:25 ` Ilpo Järvinen
2009-01-07 17:20 ` Inaky Perez-Gonzalez
2009-01-07 19:42 ` Ilpo Järvinen
2009-01-07 20:57 ` Inaky Perez-Gonzalez
2009-01-07 7:58 ` Inaky Perez-Gonzalez [this message]
2009-01-07 7:58 ` [PATCH 3/3] wimax: testing for rfkill support should also test for CONFIG_RFKILL_MODULE Inaky Perez-Gonzalez
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 17:18 [PATCH 0/3] wimax: Kbuild / rfkill-build fixes (v2) Inaky Perez-Gonzalez
2009-01-07 17:18 ` [PATCH 2/3] wimax: fix kconfig interactions with rfkill and input layers Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c2fff491400cdec32b405fba1f2ead93ca40901.1231314782.git.inaky@linux.intel.com \
--to=inaky@linux.intel.com \
--cc=greg@kroah.com \
--cc=netdev@vger.kernel.org \
--cc=wimax@linuxwimax.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).