From: Vincent Whitchurch <Vincent.Whitchurch@axis.com>
To: "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"nbd@nbd.name" <nbd@nbd.name>,
Vincent Whitchurch <Vincent.Whitchurch@axis.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
kernel <kernel@axis.com>
Subject: Re: [PATCH net] net: stmmac: Use hrtimer for TX coalescing
Date: Fri, 8 Sep 2023 10:42:22 +0000 [thread overview]
Message-ID: <7c35a48ea40d7d7aeed81e29eb13af5562a481ab.camel@axis.com> (raw)
In-Reply-To: <44ebe3fd-5898-4e48-a642-ee7457c0c032@nbd.name>
On Fri, 2023-09-01 at 13:53 +0200, Felix Fietkau wrote:
> Could you please post your fix? I think in order to avoid accidental
> breakage, we should make tx-usecs=0 imply tx-frames=1.
I've posted a fix to make tx-usecs=0 not use the timer. The driver
already rejects the invalid setting of tx-frames=0 tx-usecs=0.
https://lore.kernel.org/netdev/20230907-stmmac-coaloff-v2-1-38ccfac548b9@axis.com/
prev parent reply other threads:[~2023-09-08 10:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 15:02 [PATCH net] net: stmmac: Use hrtimer for TX coalescing Vincent Whitchurch
2020-11-24 0:46 ` Jakub Kicinski
2020-11-24 4:11 ` Vincent Whitchurch
2020-11-24 16:50 ` Jakub Kicinski
2023-08-23 20:18 ` Felix Fietkau
2023-08-25 13:42 ` Vincent Whitchurch
2023-08-25 17:38 ` Felix Fietkau
2023-08-30 14:55 ` Vincent Whitchurch
2023-08-30 18:05 ` Maxim Mikityanskiy
2023-09-18 12:56 ` Vincent Whitchurch
2023-09-19 17:53 ` Maxim Mikityanskiy
2023-08-30 21:06 ` Felix Fietkau
2023-09-01 11:31 ` Vincent Whitchurch
2023-09-01 11:53 ` Felix Fietkau
2023-09-08 10:42 ` Vincent Whitchurch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c35a48ea40d7d7aeed81e29eb13af5562a481ab.camel@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kernel@axis.com \
--cc=kuba@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).