From mboxrd@z Thu Jan  1 00:00:00 1970
From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Subject: Re: [PATCH iproute2-next] ip-xfrm: Add support for OUTPUT_MARK
Date: Tue, 12 Jun 2018 12:51:37 -0600
Message-ID: <7c486bcbac7302616f1bd651b4d2baad@codeaurora.org>
References: <1528769493-25435-1-git-send-email-subashab@codeaurora.org>
 <CAKD1Yr0Z8ZgyE=b2MXtGOaJSRm0Y8spnU2pDxuWLd5FFgfx=eQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org,
        Stephen Hemminger <stephen@networkplumber.org>,
        David Ahern <dsahern@gmail.com>,
        Steffen Klassert <steffen.klassert@secunet.com>
To: Lorenzo Colitti <lorenzo@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtp.codeaurora.org ([198.145.29.96]:52550 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753912AbeFLSvi (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 12 Jun 2018 14:51:38 -0400
In-Reply-To: <CAKD1Yr0Z8ZgyE=b2MXtGOaJSRm0Y8spnU2pDxuWLd5FFgfx=eQ@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Have you considered putting this earlier up in the output, where the
> mark is printed as well?
> 
>> +       if (tb[XFRMA_OUTPUT_MARK]) {
>> +               __u32 output_mark = 
>> rta_getattr_u32(tb[XFRMA_OUTPUT_MARK]);
>> +
>> +               fprintf(fp, "\toutput-mark 0x%x %s", output_mark, 
>> _SL_);
>> +       }
>>  }
> 
> If you wanted to implement the suggestion above, I think you could do
> that by moving this code into xfrm_xfrma_print.
> 

Hi Lorenzo

I have updated it now in v2.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project