Netdev List
 help / color / mirror / Atom feed
From: <Parthiban.Veerasooran@microchip.com>
To: <andrew@lunn.ch>, <conor@kernel.org>
Cc: <Selvamani.Rajagopal@onsemi.com>, <andrew+netdev@lunn.ch>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <Pier.Beruto@onsemi.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<Conor.Dooley@microchip.com>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH net v3 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered
Date: Mon, 8 Jun 2026 04:13:47 +0000	[thread overview]
Message-ID: <7c68173a-ebff-42cc-8519-95e8365805b5@microchip.com> (raw)
In-Reply-To: <4df9882b-3426-4c36-8048-0c76d0f11c74@lunn.ch>

On 04/06/26 10:30 pm, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> I just made the assumption that what was in the example worked, and
>> wanted clarification that what the example was changed to actually
>> reflected something else that worked on the hardware in question before
>> I gave an ack.
> 
> That is the problem with edge interrupts when level should be
> used. They work %99.9 of the time, so many developers don't notice
> they have it wrong. And then one day it all stops because an interrupt
> got lost.
I agree with this point. But simply changing the interrupt type in the 
existing logic is not sufficient. Level‑triggered interrupts require 
careful handling in the driver, and with the current implementation I am 
observing issues under system load when using level‑triggered IRQs, as 
also discussed in another thread.

Best regards,
Parthiban V
> 
>      Andrew


  reply	other threads:[~2026-06-08  4:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 16:07 [PATCH net v3 0/2] Resubmitting with cover-letter and threaded patch series Selvamani Rajagopal via B4 Relay
2026-06-01 16:07 ` [PATCH net v3 1/2] net: ethernet: oa_tc6: Interrupt is active low, level triggered Selvamani Rajagopal via B4 Relay
2026-06-01 16:07 ` [PATCH net v3 2/2] dt-bindings: net: updated interrupt type to be " Selvamani Rajagopal via B4 Relay
2026-06-02 16:42   ` Conor Dooley
2026-06-02 17:36     ` Selvamani Rajagopal
2026-06-03 15:08       ` Conor Dooley
2026-06-04  6:29       ` Parthiban.Veerasooran
2026-06-04  7:08         ` Nicolai Buchwitz
2026-06-04 15:21         ` Selvamani Rajagopal
2026-06-04 16:36           ` Conor Dooley
2026-06-04 17:00             ` Andrew Lunn
2026-06-08  4:13               ` Parthiban.Veerasooran [this message]
2026-06-08  4:44                 ` Selvamani Rajagopal
2026-06-08  7:15                   ` Andrew Lunn
2026-06-08 15:04                     ` Selvamani Rajagopal
2026-06-09  9:15                   ` Parthiban.Veerasooran
2026-06-04 13:19 ` [PATCH net v3 0/2] Resubmitting with cover-letter and threaded patch series Paolo Abeni
2026-06-04 14:51   ` Selvamani Rajagopal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c68173a-ebff-42cc-8519-95e8365805b5@microchip.com \
    --to=parthiban.veerasooran@microchip.com \
    --cc=Conor.Dooley@microchip.com \
    --cc=Pier.Beruto@onsemi.com \
    --cc=Selvamani.Rajagopal@onsemi.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox