From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:53782 "EHLO
        mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751531AbeCXCl6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 23 Mar 2018 22:41:58 -0400
Subject: Re: [PATCH v5 bpf-next 00/10] bpf, tracing: introduce bpf raw
 tracepoints
To: <davem@davemloft.net>
References: <20180324023038.938665-1-ast@fb.com>
CC: <daniel@iogearbox.net>, <torvalds@linux-foundation.org>,
        <peterz@infradead.org>, <rostedt@goodmis.org>,
        <netdev@vger.kernel.org>, <kernel-team@fb.com>,
        <linux-api@vger.kernel.org>
From: Alexei Starovoitov <ast@fb.com>
Message-ID: <7c9262c0-d554-fa1e-294d-c07c499ed845@fb.com>
Date: Fri, 23 Mar 2018 19:35:59 -0700
MIME-Version: 1.0
In-Reply-To: <20180324023038.938665-1-ast@fb.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 3/23/18 7:30 PM, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
>
> v4->v5:
> - adopted Daniel's fancy REPEAT macro in bpf_trace.c in patch 7

Daniel,
if you don't mind I'd like to land the patch set in this shape
and you can follow up with additional macro magic,
since I don't understand how the UNPACK part of it works.
It sort of looks unnecessary, but if remove it then (,) doesn't
get 'unpacked' into single comma.
Yet if __DL_COM is defined as , without ()
then nothing works. My brain is hurting.