From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gao Feng" Subject: Re:Re: Re: Re: [PATCH net] net: Correct wrong skb_flow_limit check when enable RPS Date: Mon, 14 May 2018 09:26:21 +0800 (CST) Message-ID: <7c95f360.2804.1635c416d55.Coremail.gfree.wind@vip.163.com> References: <1525940884-21067-1-git-send-email-gfree.wind@vip.163.com> <7353417.5279.1634ddbc882.Coremail.gfree.wind@vip.163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 Cc: "davem@davemloft.net" , "daniel@iogearbox.net" , "jakub.kicinski@netronome.com" , "David Ahern" , "netdev@vger.kernel.org" To: "Willem de Bruijn" Return-path: Received: from m174-177.vip.163.com ([123.58.177.174]:49646 "EHLO m174-177.vip.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbeENBcM (ORCPT ); Sun, 13 May 2018 21:32:12 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: QXQgMjAxOC0wNS0xMSAyMjo1NjowNCwgIldpbGxlbSBkZSBCcnVpam4iIDx3aWxsZW1kZWJydWlq bi5rZXJuZWxAZ21haWwuY29tPiB3cm90ZToKPk9uIEZyaSwgTWF5IDExLCAyMDE4IGF0IDEwOjQ0 IEFNLCBHYW8gRmVuZyA8Z2ZyZWUud2luZEB2aXAuMTYzLmNvbT4gd3JvdGU6Cj4+IEF0IDIwMTgt MDUtMTEgMjE6MjM6NTUsICJXaWxsZW0gZGUgQnJ1aWpuIiA8d2lsbGVtZGVicnVpam4ua2VybmVs QGdtYWlsLmNvbT4gd3JvdGU6Cj4+Pk9uIEZyaSwgTWF5IDExLCAyMDE4IGF0IDI6MjAgQU0sIEdh byBGZW5nIDxnZnJlZS53aW5kQHZpcC4xNjMuY29tPiB3cm90ZToKPj4+PiBBdCAyMDE4LTA1LTEx IDExOjU0OjU1LCAiV2lsbGVtIGRlIEJydWlqbiIgPHdpbGxlbWRlYnJ1aWpuLmtlcm5lbEBnbWFp bC5jb20+IHdyb3RlOgo+Pj4+Pk9uIFRodSwgTWF5IDEwLCAyMDE4IGF0IDQ6MjggQU0sICA8Z2Zy ZWUud2luZEB2aXAuMTYzLmNvbT4gd3JvdGU6Cj4+Pj4+PiBGcm9tOiBHYW8gRmVuZyA8Z2ZyZWUu d2luZEB2aXAuMTYzLmNvbT4KPj4+Pj4+Cj4+Pj4+PiBUaGUgc2tiIGZsb3cgbGltaXQgaXMgaW1w bGVtZW50ZWQgZm9yIGVhY2ggQ1BVIGluZGVwZW5kZW50bHkuIEluIHRoZQo+Pj4+Pj4gY3VycmVu dCBjb2RlcywgdGhlIGZ1bmN0aW9uIHNrYl9mbG93X2xpbWl0IGdldHMgdGhlIHNvZnRuZXRfZGF0 YSBieQo+Pj4+Pj4gdGhpc19jcHVfcHRyLiBCdXQgdGhlIHRhcmdldCBjcHUgb2YgZW5xdWV1ZV90 b19iYWNrbG9nIHdvdWxkIGJlIG5vdAo+Pj4+Pj4gdGhlIGN1cnJlbnQgY3B1IHdoZW4gZW5hYmxl IFJQUy4gQXMgdGhlIHJlc3VsdCwgdGhlIHNrYl9mbG93X2xpbWl0IGNoZWNrcwo+Pj4+Pj4gdGhl IHN0YXRzIG9mIGN1cnJlbnQgQ1BVLCB3aGlsZSB0aGUgc2tiIGlzIGdvaW5nIHRvIGFwcGVuZCB0 aGUgcXVldWUgb2YKPj4+Pj4+IGFub3RoZXIgQ1BVLiBJdCBpc24ndCB0aGUgZXhwZWN0ZWQgYmVo YXZpb3IuCj4+Pj4+Pgo+Pj4+Pj4gTm93IHBhc3MgdGhlIHNvZnRuZXRfZGF0YSBhcyBhIHBhcmFt IHRvIHNvZnRuZXRfZGF0YSB0byBtYWtlIGNvbnNpc3RlbnQuCj4+Pj4+Cj4+Pj4+VGhlIGxvY2Fs IGNwdSBzb2Z0bmV0X2RhdGEgaXMgdXNlZCBvbiBwdXJwb3NlLiBUaGUgb3BlcmF0aW9ucyBpbgo+ Pj4+PnNrYl9mbG93X2xpbWl0KCkgb24gc2QgZmllbGRzIGNvdWxkIHJhY2UgaWYgbm90IGV4ZWN1 dGVkIG9uIHRoZSBsb2NhbCBjcHUuCj4+Pj4KPj4+PiBJIHRoaW5rIHRoZSByYWNlIGRvZXNuJ3Qg ZXhpc3QgYmVjYXVzZSBvZiB0aGUgcnBzX2xvY2suCj4+Pj4gVGhlIGVucXVldWVfdG9fYmFja2xv ZyBoYXMgaG9sZCB0aGUgcnBzX2xvY2sgYmVmb3JlIHNrYl9mbG93X2xpbWl0Lgo+Pj4KPj4+SW5k ZWVkLCBJIG92ZXJsb29rZWQgdGhhdC4gVGhlcmUgc3RpbGwgaXMgdGhlIG1hdHRlciBvZiBjYWNo ZSBjb250ZW50aW9uLgo+Pgo+PiBUaGUgY2FjaGUgY29udGVudGlvbiBpcyByZWFsbHkgaW1wb3J0 YW50IGluIHRoaXMgY2FzZT8KPj4gSSBkb24ndCB0aGluayBzbywgYmVjYXVzZSB0aGUgZW5xdWV1 ZV90b19iYWNrbG9nIGhhdmUgdG91Y2hlZCBhbmQgbW9kaWZpZWQgdGhlIHNvZnRuZXRfc3RhdAo+ PiBvZiB0YXJnZXQgY3B1Lgo+Pgo+Pj4KPj4+Pj5GbG93IGxpbWl0IHRyaWVzIHRvIGRldGVjdCBs YXJnZSAoImVsZXBoYW50IikgRG9TIGZsb3dzIHdpdGggYSBmaXhlZCBmb3VyLXR1cGxlLgo+Pj4+ PlRoZXNlIHdvdWxkIGFsd2F5cyBoaXQgdGhlIHNhbWUgUlBTIGNwdSwgc28gdGhhdCBjcHUgYmVp bmcgYmFja2xvZ2dlZAo+Pj4+Cj4+Pj4gVGhleSBtYXkgaGl0IHRoZSBkaWZmZXJlbnQgdGFyZ2V0 IENQVSB3aGVuIGVuYWJsZSBSRlMuIEJlY2F1c2UgdGhlIGFwcCBjb3VsZCBiZSBzY2hlZHVsZWQK Pj4+PiB0byBhbm90aGVyIENQVSwgdGhlbiBSRlMgdHJpZXMgdG8gZGVsaXZlciB0aGUgc2tiIHRv IGxhdGVzdCBjb3JlIHdoaWNoIGhhcyBob3QgY2FjaGUuCj4+Pgo+Pj5UaGlzIGV2ZW4gbW9yZSBz dWdnZXN0IHVzaW5nIHRoZSBpbml0aWFsIChvciBJUlEpIGNwdSB0byB0cmFjayBzdGF0ZSwgaW5z dGVhZAo+Pj5vZiB0aGUgZGVzdGluYXRpb24gKFJQUy9SRlMpIGNwdS4KPj4KPj4gSSBjb3VsZG4n dCB1bmRlcnN0YW5kIHdoeSBpdCBpcyBiZXR0ZXIgdG8gdHJhY2sgc3RhdGUgb24gaW5pdGlhbCBj cHUsIG5vdCB0aGUgdGFyZ2V0IGNwdS4KPj4gVGhlIGxhdHRlciBvbmUgY291bGQgZ2V0IG1vcmUg YWNjdXJhdGUgcmVzdWx0Lgo+Cj5Gb3IgYSBzaW5nbGUgRG9TIGZsb3cgd2l0aCBub3JtYWwgY3B1 IHBpbm5lZCBJUlFzLCB0aGUgcmVzdWx0cyB3aWxsIGJlIGVxdWFsbHkKPmdvb2Qgd2hlbiB0cmFj a2VkIG9uIHRoZSBpbml0aWFsIElSUSBjcHUuLgo+Cj4+Cj4+Pgo+Pj4+Pm1heSBiZSBhbiBpbmRp Y2F0aW9uIHRoYXQgc3VjaCBhIGZsb3cgaXMgYWN0aXZlLiBCdXQgdGhlIGZsb3cgd2lsbCBhbHNv IGFsd2F5cwo+Pj4+PmFycml2ZSBvbiB0aGUgc2FtZSBpbml0aWFsIGNwdSBjb3VydGVzeSBvZiBS U1MuIFNvIHN0b3JpbmcgdGhlIGxvb2t1cCB0YWJsZQo+Pj4+Cj4+Pj4gVGhlIFJTUyBjb3VsZG4n dCBtYWtlIHN1cmUgdGhlIGlycSBpcyBoYW5kbGVkIGJ5IHNhbWUgY3B1LiBJdCB3b3VsZCBiZSBi YWxhbmNlZCBiZXR3ZWVuCj4+Pj4gdGhlIGNwdXMuCj4+Pgo+Pj5JUlFzIGFyZSB1c3VhbGx5IHBp bm5lZCB0byBjb3Jlcy4gVW5sZXNzIHVzaW5nIHNvbWV0aGluZyBsaWtlIGlycWJhbGFuY2UsCj4+ PmJ1dCB0aGF0IG9wZXJhdGVzIGF0IHRvbyBjb2Fyc2UgYSB0aW1lc2NhbGUgdG8gZG8gYW55dGhp bmcgdXNlZnVsIGF0IE1wcHMKPj4+cGFja2V0IHJhdGVzLgo+Pgo+PiBUaGVyZSBhcmUgc29tZSBt b3RoZXJib2FyZCB3aGljaCBjb3VsZG4ndCBtYWtlIHN1cmUgdGhlIGlycSBpcyBwaW5uZWQuCj4+ IFRoZSBmbG93X2xpbWl0IHdvdWxkbid0IHdvcmsgYXMgd2VsbCBhcyBleHBlY3RlZC4KPgo+Li4g dGhpcyBzZWVtcyB0byBiZSB0aGUgY3J1eCBvZiB0aGUgYXJndW1lbnQuIEkgYW0gbm90IGF3YXJl IG9mIGFueSBuZXR3b3JrCj5pbnRlcnJ1cHRzIHRoYXQgZG8gbm90IGFkaGVyZSB0byB0aGUgY3B1 IHBpbm5pbmcgY29uZmlndXJhdGlvbiBpbgo+Cj4gICAvcHJvYy9pcnEvJElSUS9zbXBfYWZmaW5p dHkoX2xpc3QpCj4KCldoZW4gc21wX2FmZmluaXR5IGlzIGNvbmZpZ3VyZWQgMHhmZiwgSSBtZXQg c29tZSBoYXJkd2FyZXMgdGhleSBkZWxpdmVyIG1vc3Qgb2YKaXJxcyB0byBhIHNwZWNpZmljIGNw dSwgYW5kIGxlZnQgaXJxcyBhcmUgc3ByZWFkIHRvIHRoZSBvdGhlciBjcHVzLiBBbmQgaXQgY291 bGRuJ3QgCm1ha2Ugc3VyZSB0aGUgaXJxIG9mIG9uZSBmbG93IGlzIGRlbGl2ZXJlZCB0byBhIGZp eGVkIGNwdS4KCkkgZG9uJ3Qga25vdyBpZiBpdCBpcyBjYXVzZWQgYnkgYXBpYyBvciBtb3RoZXJi b2FyZC4KQW5kIHdoYXQgaW5mb3JtYXRpb24geW91IG5lZWQgdG8gY29uZmlybSBpdC4KCj5XaGF0 IGtpbmQgb2YgaGFyZHdhcmUgaWdub3JlcyB0aGlzIHNldHRpbmcgYW5kIHNwcmF5cyBpbnRlcnJ1 cHRzPyBJIGFncmVlCj50aGF0IGluIHRoYXQgY2FzZSBmbG93X2xpbWl0IGFzIGlzIG1heSBiZSBp bmVmZmVjdGl2ZSAoaWYgbWlncmF0aW9uIGhhcHBlbnMKPmF0IHJhdGVzIGNvbXBhcmFibGUgdG8g cGFja2V0IHJhdGVzKS4gQnV0IHRoaXMgc2hvdWxkIG5vdCBoYXBwZW4/Cj4KPj4KPj4+Cj4+Pj4+ b24gdGhlIGluaXRpYWwgQ1BVIGlzIGFsc28gZmluZS4gVGhlcmUgbWF5IGJlIGZhbHNlIHBvc2l0 aXZlcyBvbiBvdGhlciBDUFVzCj4+Pj4+d2l0aCB0aGUgc2FtZSBSUFMgZGVzdGluYXRpb24sIGJ1 dCB0aGF0IGlzIHVubGlrZWx5IHdpdGggYSBoaWdobHkgY29uY3VycmVudAo+Pj4+PnRyYWZmaWMg c2VydmVyIG1peCAoIm1pY2UiKS4KPj4+Pgo+Pj4+IElmIG15IGNvbW1lbnQgaXMgcmlnaHQsIHRo ZSBmbG93IGNvdWxkbid0IGFsd2F5cyBhcnJpdmUgb25lIHRoZSBzYW1lIGluaXRpYWwgY3B1LCAg YWx0aG91Z2gKPj4+PiBpdCBtYXkgYmUgc2VudCB0byBvbmUgc2FtZSB0YXJnZXQgY3B1Lgo+Pj4+ Cj4+Pj4+Cj4+Pj4+Tm90ZSB0aGF0IHRoZSBzeXNjdGwgbmV0LmNvcmUuZmxvd19saW1pdF9jcHVf Yml0bWFwIGVuYWJsZXMgdGhlIGZlYXR1cmUKPj4+Pj5mb3IgdGhlIGNwdXMgb24gd2hpY2ggdHJh ZmZpYyBpbml0aWFsbHkgbGFuZHMsIG5vdCB0aGUgUlBTIGRlc3RpbmF0aW9uIGNwdXMuCj4+Pj4+ U2VlIGFsc28gRG9jdW1lbnRhdGlvbi9uZXR3b3JraW5nL3NjYWxpbmcudHh0Cj4+Pj4+Cj4+Pj4+ VGhhdCBzYWlkLCBJIGhhZCB0byByZXJlYWQgdGhlIGNvZGUsIGFzIGl0IGRvZXMgc2VlbSBzZW5z aWJsZSB0aGF0IHRoZQo+Pj4+PnNhbWUgc29mdG5ldF9kYXRhIGlzIGludGVuZGVkIHRvIGJlIHVz ZWQgYm90aCB3aGVuIHRlc3RpbmcgcWxlbiBhbmQKPj4+Pj5mbG93X2xpbWl0Lgo+Pj4+Cj4+Pj4g SW4gbW9zdCBjYXNlcywgdXNlciBjb25maWd1cmVzIHRoZSBzYW1lIFJQUyBtYXAgd2l0aCBmbG93 X2xpbWl0IGxpa2UgMHhmZi4KPj4+PiBCZWNhdXNlIHVzZXIgY291bGRuJ3QgcHJlZGljdCB3aGlj aCBjb3JlIHRoZSBldmlsIGZsb3cgd291bGQgYXJyaXZlIG9uLgo+Pj4+Cj4+Pj4gVGFrZSBhbiBl eGFtcGxlLCB0aGVyZSBhcmUgMiBjb3JlcywgY3B1MCBhbmQgY3B1MS4KPj4+PiBPbmUgZmxvdyBp cyB0aGUgYW4gZXZpbCBmbG93LCBidXQgdGhlIGlycSBpcyBzZW50IHRvIGNwdTAuIEFmdGVyIFJQ Uy9SRlMsIHRoZSB0YXJnZXQgY3B1IGlzIGNwdTEuCj4+Pj4gTm93IGNwdTAgaW52b2tlcyBlbnF1 ZXVlX3RvX2JhY2tsb2csIHRoZW4gdGhlIHNrYl9mbG93X2xpbWl0IGNoZWNrZXMgdGhlIHF1ZXVl IGxlbmd0aAo+Pj4+IG9mIGNwdTAuIENlcnRhaW5seSBpdCBjb3VsZCBwYXNzIHRoZSBjaGVjayBv ZiBza2JfZmxvd19saW1pdCBiZWNhdXNlIHRoZXJlIGlzIG5vIGFueSBldmlsIGZsb3cgb24gY3B1 MC4KPj4+Cj4+Pk5vLCBlbnF1ZXVlX3RvX2JhY2tsb2cgcGFzc2VzIHFsZW4gdG8gc2tiX2Zsb3df bGltaXQsIHNvIHRoYXQgZG9lcwo+Pj5jaGVjayB0aGUgcXVldWUgbGVuZ3RoIG9mIHRoZSBSUFMg Y3B1Lgo+Pgo+PiBTb3JyeSwgSSBvdmVybG9va2VkIHRoZSBxbGVuIGlzIHRoZSBsZW5ndGggb2Yg dGhlIHJwcyBjcHUuCj4+IFRoZW4gaXQncyBvayB1bmxlc3MgdGhlIHN0YXRzIG1heSBiZSBub3Qg YWNjdXJhdGUgd2hlbiBpcnEgaXNuJ3QgcGlubmVkLgo+Pgo+PiBCdXQgSSBzdGlsbCBkb3VidCB0 aGF0IGlzIGl0IHJlYWxseSBpbXBvcnRhbnQgdG8gdHJhY2sgc3RhdGUgb24gaW5pdGlhbCBjcHUs IG5vdCB0YXJnZXQgY3B1Pwo+PiBCZWNhdXNlIHRoZSBlbnF1ZXVlX3RvX2JhY2tsb2cgaGF2ZSB0 b3VjaGVkIHRoZSBzb2Z0bmV0X2RhdGEgb2YgdGFyZ2V0IGNwdS4KPgo+SSB0aGluayB0aGUgbWVy aXQgb2YgYm90aCBJUlEgYW5kIFJQUyBjcHUgY2FuIGJlIGFyZ3VlZCBmb3IgYXR0YWNoaW5nIHRo ZQo+Zmxvd19saW1pdCBzdGF0ZS4KPgo+RWl0aGVyIHdheSwgdGhlIGN1cnJlbnQgYmVoYXZpb3Ig aXMgbm90IGEgYnVnLCBzbyBJIGRvbid0IHRoaW5rIHRoYXQgdGhpcyBpcyBhCj5jYW5kaWRhdGUg Zm9yIG5ldC4KPgo+VGhlIGNvc3Qgb2YgbW92aW5nIGZyb20gSVJRIHRvIFJQUyBjcHUgd2lsbCBi ZSB0aGUgY2FjaGVsaW5lIGNvbnRlbnRpb24KPm9uIGEgc3lzdGVtIHdpdGggbXVsdGlwbGUgSVJR IGNwdXMgdGhhdCBhbGwgdHJ5IHRvIHVwZGF0ZSB0aGUgc2QtPmZsb3dfZGF0YQo+b2YgdGhlIHNh bWUgUlBTIGNwdXMuIFdoaWNoIGlzIHBhcnRpY3VsYXJseSBsaWtlbHkgd2l0aCBSRlMuIEkgc3Vz cGVjdCB0aGF0Cj50aGlzIGNvc3QgaXMgbm9uLXRyaXZpYWwgYW5kIG5vdCB3b3J0aCB0aGUgYmVu ZWZpdCBvZiBoYW5kbGluZyBoYXJkd2FyZSB3aXRoCj51bnBpbm5lZCBJUlFzLgoKT2ssIEkgYWdy ZWUgd2l0aCB5b3UuClRoYW5rcyB5b3VyIGRldGFpbCBkaXNjdXNzaW9uIHdpdGggbWUuCgpCZXN0 IFJlZ2FyZHMKRmVuZwo=