From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ying Xue Subject: Re: [PATCH] tipc: mark expected switch fall-throughs Date: Thu, 5 Jul 2018 13:57:02 +0800 Message-ID: <7c9bd75f-a3e4-79fd-b7e7-79aeb42fbb50@windriver.com> References: <20180704211359.GA9836@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: , , To: "Gustavo A. R. Silva" , Jon Maloy , "David S. Miller" Return-path: In-Reply-To: <20180704211359.GA9836@embeddedor.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 07/05/2018 05:13 AM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Warning level 2 was used: -Wimplicit-fallthrough=2 > > Signed-off-by: Gustavo A. R. Silva Acked-by: Ying Xue > --- > net/tipc/bearer.c | 1 + > net/tipc/link.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c > index 2dfb492..fd6d8f1 100644 > --- a/net/tipc/bearer.c > +++ b/net/tipc/bearer.c > @@ -610,6 +610,7 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt, > case NETDEV_CHANGE: > if (netif_carrier_ok(dev)) > break; > + /* else: fall through */ > case NETDEV_UP: > test_and_set_bit_lock(0, &b->up); > break; > diff --git a/net/tipc/link.c b/net/tipc/link.c > index 695acb7..6386032 100644 > --- a/net/tipc/link.c > +++ b/net/tipc/link.c > @@ -1063,6 +1063,7 @@ static bool tipc_data_input(struct tipc_link *l, struct sk_buff *skb, > skb_queue_tail(mc_inputq, skb); > return true; > } > + /* else: fall through */ > case CONN_MANAGER: > skb_queue_tail(inputq, skb); > return true; >