From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44480C433E0 for ; Thu, 21 Jan 2021 04:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3A5A238E5 for ; Thu, 21 Jan 2021 04:39:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728040AbhAUEiD (ORCPT ); Wed, 20 Jan 2021 23:38:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727336AbhAUEGF (ORCPT ); Wed, 20 Jan 2021 23:06:05 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4337C0613D6 for ; Wed, 20 Jan 2021 20:05:15 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id m5so751560pjv.5 for ; Wed, 20 Jan 2021 20:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PrXnwIzdiZa8p1+4jAjt67vrk+owSCcZ6LP6GOg/4/w=; b=eGvGVu3njic6ihiPEjxSrRSu8hu2AjrfGdH++NeguybDMGDX9u/JSBos27eVmzLs96 wPeX1ggVV23xi/PhzjU4LNrcKREqZIm2I5Emwbj50aLOtfStj3OGDnZgEgd4G23LUaqY rsYygbQ76b5FYodOF5Gy/4ln0WAlYzn3lLBONp8GttPpHC21PddwEg2cqFU1DaHwOjd5 g35jQ6k8A9GtWEuzJeOtNCE9cjyDFrUb1jYMhWyVyMLAAYu2kGylisxpknKMZkNpciHT WtjPmHZc+ug2w+DEI4vK/NfRMe4D87EhL5xLlA27Nn4QpL+nXojQS0SuHky2cX8wy0vS g3KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PrXnwIzdiZa8p1+4jAjt67vrk+owSCcZ6LP6GOg/4/w=; b=BQ8ZuA+Hevc31PR+AwSG5xQ4c0cZnOP6VjqU5IriF9zWJFMac6VC9jSGKn0KLZDdGK qdel7k2yBySdfSmVSefh5pRugbBthQDSUopY+1y6D8kOBClcJ73Y4+Cu/iA3ejlhfLyC uc/v02AC/vEXLyy3IcfGdMJlhAscla34ZaiNmxE4b/icZsRajbj9CFyRRYPL77d5OPad a/W9onE+c9mfpRCZUr8iFzhPavtOv/RftYBrK+rdkvXVbe0ZDTAE2Hy2j3NgAHQLs3DZ RQ962z4U29IblrWQ+Dx3dp6zBsZvPKioDIf5zyyJL6pX01R3xRfImoGGk3zmPBUj7s57 M9qQ== X-Gm-Message-State: AOAM531obK6zdoOV/b3OR5uAdU+ElUGNqF9me7f3ONJEOqu+Bd+JB2fe Qr/9rwIg+9SJmrNcFTvVLsg= X-Google-Smtp-Source: ABdhPJzF7AnY4vIk02VAnmwc/MVZPiov4GvGMGA/ggo7+jDktn/uBxiYcTz+SjElgCYdciuDq5JtPw== X-Received: by 2002:a17:90b:11d8:: with SMTP id gv24mr9322536pjb.232.1611201915268; Wed, 20 Jan 2021 20:05:15 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id i67sm3902207pfc.153.2021.01.20.20.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 20:05:14 -0800 (PST) Subject: Re: [PATCH v5 net-next 09/10] net: dsa: add a second tagger for Ocelot switches based on tag_8021q To: Vladimir Oltean , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Richard Cochran , Claudiu Manoil , Alexandru Marginean , Alexandre Belloni , Xiaoliang Yang , Hongbo Wang , Vladimir Oltean , Po Liu , Yangbo Lu , Maxim Kochetkov , Eldar Gasanov , Andrey L , Tobias Waldekranz , UNGLinuxDriver@microchip.com References: <20210121023616.1696021-1-olteanv@gmail.com> <20210121023616.1696021-10-olteanv@gmail.com> From: Florian Fainelli Message-ID: <7cd5d30d-e93a-9651-61f1-9f406d7f11a1@gmail.com> Date: Wed, 20 Jan 2021 20:05:10 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210121023616.1696021-10-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/20/2021 6:36 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > There are use cases for which the existing tagger, based on the NPI > (Node Processor Interface) functionality, is insufficient. > > Namely: > - Frames injected through the NPI port bypass the frame analyzer, so no > source address learning is performed, no TSN stream classification, > etc. > - Flow control is not functional over an NPI port (PAUSE frames are > encapsulated in the same Extraction Frame Header as all other frames) > - There can be at most one NPI port configured for an Ocelot switch. But > in NXP LS1028A and T1040 there are two Ethernet CPU ports. The non-NPI > port is currently either disabled, or operated as a plain user port > (albeit an internally-facing one). Having the ability to configure the > two CPU ports symmetrically could pave the way for e.g. creating a LAG > between them, to increase bandwidth seamlessly for the system. > > So there is a desire to have an alternative to the NPI mode. This change > keeps the default tagger for the Seville and Felix switches as "ocelot", > but it can be changed via the following device attribute: > > echo ocelot-8021q > /sys/class//dsa/tagging > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian