From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thibaut VARENE" Subject: [BUG] in skge.c on 2.6.18-rc5 Date: Wed, 30 Aug 2006 17:30:46 +0200 Message-ID: <7d01f9f00608300830j74871672o31b9ce126ee8c07d@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from py-out-1112.google.com ([64.233.166.179]:40418 "EHLO py-out-1112.google.com") by vger.kernel.org with ESMTP id S1751024AbWH3Par (ORCPT ); Wed, 30 Aug 2006 11:30:47 -0400 Received: by py-out-1112.google.com with SMTP id n25so328257pyg for ; Wed, 30 Aug 2006 08:30:46 -0700 (PDT) To: shemminger@osdl.org, netdev@vger.kernel.org, "Jeff Garzik" Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi, The following commit: commit 239e44e1f05e2163ee066c07a753f9fb445979b2 Author: Edgar E. Iglesias Date: Mon Aug 14 23:00:24 2006 -0700 [PATCH] skge: remember to run netif_poll_disable() Signed-off-by: Edgar E. Iglesias Cc: Stephen Hemminger Cc: Jeff Garzik Signed-off-by: Andrew Morton Signed-off-by: Jeff Garzik diff --git a/drivers/net/skge.c b/drivers/net/skge.c index 7de9a07..ad878df 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -2211,6 +2211,7 @@ static int skge_up(struct net_device *de skge_write8(hw, Q_ADDR(rxqaddr[port], Q_CSR), CSR_START | CSR_IRQ_CL_F); skge_led(skge, LED_MODE_ON); + netif_poll_enable(dev); return 0; free_rx_ring: @@ -2279,6 +2280,7 @@ static int skge_down(struct net_device * skge_led(skge, LED_MODE_OFF); + netif_poll_disable(dev); skge_tx_clean(skge); skge_rx_clean(skge); panics my 2.6.18-rc5 kernel on my em64t box apparently on first network activity (eg 'ping'). Reverting it gets me back to a functional kernel. HTH T-Bone varenet@PeroPero:~$ lspci | grep Ethernet 02:00.0 Ethernet controller: Marvell Technology Group Ltd. Unknown device 4364 (rev 12) 05:04.0 Ethernet controller: Marvell Technology Group Ltd. 88E8001 Gigabit Ethernet Controller (rev 13) -- Thibaut VARENE http://www.parisc-linux.org/~varenet/