From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDF7C282DA for ; Sun, 7 Apr 2019 02:45:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7694D2133F for ; Sun, 7 Apr 2019 02:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbfDGCpF (ORCPT ); Sat, 6 Apr 2019 22:45:05 -0400 Received: from mga04.intel.com ([192.55.52.120]:45101 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbfDGCpE (ORCPT ); Sat, 6 Apr 2019 22:45:04 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2019 19:45:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,319,1549958400"; d="scan'208";a="221226004" Received: from samudral-mobl1.amr.corp.intel.com (HELO [10.255.71.188]) ([10.255.71.188]) by orsmga001.jf.intel.com with ESMTP; 06 Apr 2019 19:45:03 -0700 Subject: Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces To: si-wei liu , Stephen Hemminger , "Michael S. Tsirkin" Cc: davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com References: <1554267167-17561-1-git-send-email-si-wei.liu@oracle.com> <20190405172835-mutt-send-email-mst@kernel.org> <20190405144750.441e396f@shemminger-XPS-13-9360> From: "Samudrala, Sridhar" Message-ID: <7d1c3488-2d55-213f-b744-c71b665aa387@intel.com> Date: Sat, 6 Apr 2019 19:45:02 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/6/2019 12:21 AM, si-wei liu wrote: >>> >>> Stephen are you happy with this approach? >> I think it is the best solution for what you want to do. > > Since you're asking specifically, I tried what you suggested below. > >> Did you test with some things like Free Range Routing, > > Although there might be spurious warning (which is a check for sanity > more than an error) while slave interface is up, slave rename had been > handled quite well there, no matter which state slave is at. > > https://github.com/FRRouting/frr/blob/master/zebra/if_netlink.c#L97 > > The FRR users are supposed to operate on failover master interface > anyway. No one is expected to configure those passive interfaces for > routing. > >> VPP > Nothing particular was seen for this one. The netlink usage there > doesn't seem related to my change: > https://github.com/FDio/vpp/blob/master/src/vnet/devices/netlink.c > >> or other userspace >> control planes that consume netlink? > dhcpcd (https://github.com/kobolabs/dhcpcd/blob/kobo/if-linux.c#L761) > was tested OK. > > In addition, the patch seems to play quite well with systemd-udev and > dracut/initramfs-tools. No breakage, no weird error message was seen. > > What else do you suggest we should try/test with? Thanks Siwei for all the tests you are trying out. Did you notice that any of these tests required the NETDEV_CHANGE notifier that you added? -Sridhar