From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH bpf] tools: bpftool: return from do_event_pipe() on bad
 arguments
Date: Thu, 23 Aug 2018 20:35:09 +0300
Message-ID: <7d223b75-59ae-2b8f-ff09-7f800c6228bf@cogentembedded.com>
References: <20180823164625.5410-1-quentin.monnet@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
        netdev@vger.kernel.org, oss-drivers@netronome.com
To: Quentin Monnet <quentin.monnet@netronome.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-lf1-f66.google.com ([209.85.167.66]:42182 "EHLO
        mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726264AbeHWVF7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 23 Aug 2018 17:05:59 -0400
Received: by mail-lf1-f66.google.com with SMTP id z11-v6so4659376lff.9
        for <netdev@vger.kernel.org>; Thu, 23 Aug 2018 10:35:13 -0700 (PDT)
In-Reply-To: <20180823164625.5410-1-quentin.monnet@netronome.com>
Content-Language: en-MW
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hello!

On 08/23/2018 07:46 PM, Quentin Monnet wrote:

> When command line parsing fails in the while loop in do_event_pipe()
> because the number of arguments is incorrect or because the keyword is
> unknown, an error message is displayed, but bpfool

   bp-who? ;-)

> remains stucked in

   Stuck.

> the loop. Make sure we exit the loop upon failure.
> 
> Fixes: f412eed9dfde ("tools: bpftool: add simple perf event output reader")
> Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
[...]

MBR, Sergei