From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CB5C04AAF for ; Thu, 16 May 2019 19:18:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24DA220818 for ; Thu, 16 May 2019 19:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558034329; bh=9VtDgxBgSZUAq5u89e8QiTuoiyLbcq7MVy1eVChkY4I=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=wIVC5rqaU179ceyEUAQ0tUFtQUF3cXSuhHVjkEZdlx+jcCnE+V8NdcRGIlLLaioj3 WoffI8oMDLKOLhjkQ+8Ur+GJGdRkqCuj/OwlFf2Y0FPkf02pcv3JI5JP3ZNkPGotlA gjTUHAvCoMZT4hxKePeCBTxnyGpwCMkv0KNvBFto= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727776AbfEPTSp (ORCPT ); Thu, 16 May 2019 15:18:45 -0400 Received: from mail-it1-f193.google.com ([209.85.166.193]:55350 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727467AbfEPTSn (ORCPT ); Thu, 16 May 2019 15:18:43 -0400 Received: by mail-it1-f193.google.com with SMTP id q132so7991136itc.5 for ; Thu, 16 May 2019 12:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=y3s8+3+RBFZB3vYT3Jrj2lvbVDFl/Na95NcJWfjATK0=; b=SPb3+d/JuecxS6r8yq8gBnnYYldervfuwNcRCeyhTdCAR12LhLw+mPFdIEU+ZhvM+O 6/9GkCG9nrbE96UXSrHATtjfOAK9f9sb+hlmRa8ofAyZ/qAtnLLOiQAJ3AXAydWRq5YC Rsi8oLBij5CuGtU5qlbjuBketYG2fk38MjwCI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y3s8+3+RBFZB3vYT3Jrj2lvbVDFl/Na95NcJWfjATK0=; b=RR2wAl7Z9LMN1qRutJN1MC+CmG5ljbR2wSmKjfG7Cy6k3sjQKjcSHfYCH7+crjStGl 0ZkFvbKjS+0B4R5fP4hP4o0InkWmRUXsZ+20aQnRnkevAie/y5kDa6BgJahkgjztm+OK oEHMElmJMLO8KOBtie/TkcJyYagH6VUM7B+edbI57fJpf/2zTKHh5gdZKhcszBC9OGhF tXNdmmxi/xz2pkCeIQIOrg0gcJ2PJ1U19lGnHeiHBF8Ug9UotzO8OHC/99xRutZMjUao dcAAHn+ROwE6K2ykU5SZX7GkKRZVPD62JaC7XPClXuVtVCyXjYHmhJe8YOOCxLD0jAUZ NDjA== X-Gm-Message-State: APjAAAXYSkIaeRtENDLWcCKAaLRdKMeqhjRzvE58IH8ocudoML2znIAY CGFc1QmnQ71cgiQVswCe/Pz8qA== X-Google-Smtp-Source: APXvYqwax9luuLVEpDiRgvFjJqjCLOBRqZuw5XBpIha4imoJI4EiC7oScANCzXkTFNzOx11ON/G3rA== X-Received: by 2002:a24:2f42:: with SMTP id j63mr14194515itj.108.1558034322766; Thu, 16 May 2019 12:18:42 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id y97sm2031212ita.19.2019.05.16.12.18.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2019 12:18:42 -0700 (PDT) Subject: Re: [PATCH] selftests: fix bpf build/test workflow regression when KBUILD_OUTPUT is set To: Alexei Starovoitov Cc: Shuah Khan , Daniel Borkmann , "David S. Miller" , Linus Torvalds , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , Network Development , bpf , skhan@linuxfoundation.org References: <20190511025249.32678-1-skhan@linuxfoundation.org> <20190511043729.3o4enh35lrmne3kd@ast-mbp> From: Shuah Khan Message-ID: <7d34df4b-88f4-9be9-624c-dfcb8b82e87d@linuxfoundation.org> Date: Thu, 16 May 2019 13:18:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 5/16/19 12:36 PM, Alexei Starovoitov wrote: > On Fri, May 10, 2019 at 9:37 PM Alexei Starovoitov > wrote: >> >> On Fri, May 10, 2019 at 08:52:49PM -0600, Shuah Khan wrote: >>> commit 8ce72dc32578 ("selftests: fix headers_install circular dependency") >>> broke bpf build/test workflow. When KBUILD_OUTPUT is set, bpf objects end >>> up in KBUILD_OUTPUT build directory instead of in ../selftests/bpf. >>> >>> The following bpf workflow breaks when it can't find the test_verifier: >>> >>> cd tools/testing/selftests/bpf; make; ./test_verifier; >>> >>> Fix it to set OUTPUT only when it is undefined in lib.mk. It didn't need >>> to be set in the first place. >>> >>> Fixes: commit 8ce72dc32578 ("selftests: fix headers_install circular dependency") >>> >>> Reported-by: Alexei Starovoitov >>> Signed-off-by: Shuah Khan >> >> 'git am' couldn't apply this patch because "sha1 information is lacking", >> but the patch itself looks good. >> Acked-by: Alexei Starovoitov >> Thanks for the quick fix. > > Ping! What is the status of the fix? > Sending pull request this afternoon. thanks, -- Shuah