From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D21E91E8857 for ; Tue, 15 Oct 2024 10:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728989735; cv=none; b=e5/h6GbxBk/A3WWoFcfDpN4Hm/dgK6vNvwyrvH8F4Fqm1MxGSORmfDgIMY3XPZU4YcIwvKvQvgf6tMDGYXgxeKB/ZVJbjGAfK0rz8vpeA2/7U6G7NQlzrbh/7hG/lC+UDjAdKYx4NhvgXFI989JVWg6nBqaPXou83ewUZ2Ub0U0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728989735; c=relaxed/simple; bh=dJZxNsHufyVnVkGZ7KBRcyWcePNegdl1XvkyiSwKVwI=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=g3lwYdko3IJAoz2/qYjHxTYMd1VGDqdpZP199kkZUBHRHj8g2gig82vO5wEq2czVsM++q3cDPGRhbh75VCWVh7sY6duGZDWMp/CBPvZtlptthikg+fEhgc1hL/ZEJhSIINkTq/iRWuW41BRT9JDEO5SMryjDzc6Ijpn73w0ipCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b=FN/6EoI3; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b="FN/6EoI3" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5c9404c0d50so5416495a12.3 for ; Tue, 15 Oct 2024 03:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20230601.gappssmtp.com; s=20230601; t=1728989732; x=1729594532; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=qxWaIsUg6giBeZB/qFZgxvxYS8Q3WXg/pwadc9vI6U4=; b=FN/6EoI3dCHV7bU1thwTZfY1F7axilseOO6PvuCCFqIViQo7ynHcdA50Q1Veb2YF3e 2SfW1VxpqGhfEvmUOwxhKlGDZJ/VoHa/hYEHIRvf0hQahpE6EsPY7V6alhxZSByTeucZ zuKfbO16bFoc1oIDbkjKRrr+/gFvCGruvI3vWfvDdch9ixAMrY37lozB7gzMzEhpQntI NP/0/vgQij5f0nbe6QfbHDa3+kmCnuOg8alnfmuBRKxd0Nkfnh0TWfzUb2xvmPjW9W1+ 4bjUyQsGQzkCUHOrbs3N40LPyGy681QIpXlYG+epZgluLeja4Hbk6yEH5Q1UaZEfBi22 aXVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728989732; x=1729594532; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qxWaIsUg6giBeZB/qFZgxvxYS8Q3WXg/pwadc9vI6U4=; b=VoeOqpjzoDTVZyLSVwAxtJHhLR4MV0bpjBNUcCGCEJVehhzmqp2sccntCobjJoR/LY h9gEIoC/JI9QO1+FJX0oFfnW9jg6CiuRRkInaOKLb7hgg7hbOMz+YgmiyYt4nUWYP2xF yNW6UBZQ5zk8EtVPLx72/gFGSjidKIQrLmQ+8MQJIPSn88EfiT/d4jJxwWFFgxU2FNTd 3OY0blxJlvJ0yiud8T0QVTtei25kdNqr8glu5f6+kdl+47b7NPsEG3N8G9fdR8X3jJav 5xTIuLkP4CWufiMbmvepc2LJ8Efgsx4iRHkIchmaLMIMz92m5fbMoqrIP/mCgsW1PH4R KLyA== X-Forwarded-Encrypted: i=1; AJvYcCXBSkq9hF2NuMXfYyZQRZGf1dqYAOWXFytjjQDch19MUis49gW/ujoGC86w7w9J22KWvCyCPXk=@vger.kernel.org X-Gm-Message-State: AOJu0YwK99pRNJ/RckdvJGUr8o/R/u+gmXTFujyM1L2f5qD0hCMEVb9a 0jte1Aegu56GSgSZs3sa3sVhjBuDpIko9l2cvv+sf/3q2M/QRZoZ0QRuD5GSrHo= X-Google-Smtp-Source: AGHT+IENngL8kUtvdGqBvfWOeT0HU3Jz0wnco8VTc5j19kviovROQUzgBtOacG8vxlSE5QNA5vJkkA== X-Received: by 2002:a17:906:f59b:b0:a99:f7df:b20a with SMTP id a640c23a62f3a-a99f7dfb8ecmr782739366b.62.1728989731976; Tue, 15 Oct 2024 03:55:31 -0700 (PDT) Received: from [192.168.0.245] ([62.73.69.208]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a298232f4sm56459066b.117.2024.10.15.03.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Oct 2024 03:55:31 -0700 (PDT) Message-ID: <7d4c49da-e071-4b74-85d8-f0b5efaa0cf3@blackwall.org> Date: Tue, 15 Oct 2024 13:55:30 +0300 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] bpf: xdp: fallback to SKB mode if DRV flag is absent. From: Nikolay Aleksandrov To: Hangbin Liu Cc: Daniel Borkmann , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Jesper Dangaard Brouer , John Fastabend , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Andrii Nakryiko , Jussi Maki , Jay Vosburgh , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Liang Li References: <20241015033632.12120-1-liuhangbin@gmail.com> <8ef07e79-4812-4e02-a5d1-03a05726dd07@iogearbox.net> <2cdcad89-2677-4526-8ab5-3624d0300b7f@blackwall.org> <8088f2a7-3ab1-4a1e-996d-c15703da13cc@blackwall.org> Content-Language: en-US In-Reply-To: <8088f2a7-3ab1-4a1e-996d-c15703da13cc@blackwall.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/10/2024 13:46, Nikolay Aleksandrov wrote: > On 15/10/2024 13:38, Hangbin Liu wrote: >> On Tue, Oct 15, 2024 at 12:53:08PM +0300, Nikolay Aleksandrov wrote: >>> On 15/10/2024 11:17, Daniel Borkmann wrote: >>>> On 10/15/24 5:36 AM, Hangbin Liu wrote: >>>>> After commit c8a36f1945b2 ("bpf: xdp: Fix XDP mode when no mode flags >>>>> specified"), the mode is automatically set to XDP_MODE_DRV if the driver >>>>> implements the .ndo_bpf function. However, for drivers like bonding, which >>>>> only support native XDP for specific modes, this may result in an >>>>> "unsupported" response. >>>>> >>>>> In such cases, let's fall back to SKB mode if the user did not explicitly >>>>> request DRV mode. >>>>> >>> >>> So behaviour changed once, now it's changing again.. >> >> This should not be a behaviour change, it just follow the fallback rules. >> > > hm, what fallback rules? I see dev_xdp_attach() exits on many errors > with proper codes and extack messages, am I missing something, where's the > fallback? > Oh did you mean dev_xdp_mode()'s ndo_bpf check to decide which mode to use ? So you'd like to do that for the unsupported bond modes as well, then I'd go with Daniel's suggestion in that case and keep it in the bonding until something else needs it.