From: David Ahern <dsahern@gmail.com>
To: Mike Manning <mmanning@vyatta.att-mail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 7/9] ipv6: allow ping to link-local address in VRF
Date: Tue, 6 Nov 2018 11:14:33 -0700 [thread overview]
Message-ID: <7d5db1e7-53be-729c-cfdd-b634e97e2bc3@gmail.com> (raw)
In-Reply-To: <20181102191020.14170-8-mmanning@vyatta.att-mail.com>
On 11/2/18 1:10 PM, Mike Manning wrote:
> If link-local packets are marked as enslaved to a VRF, then to allow
> ping to the link-local from a vrf, the error handling for IPV6_PKTINFO
> needs to be relaxed to also allow the pkt ipi6_ifindex to be that of a
> slave device to the vrf.
>
> Note that the real device also needs to be retrieved in icmp6_iif()
> to set the ipv6 flow oif to this for icmp echo reply handling. The
> recent commit 24b711edfc34 ("net/ipv6: Fix linklocal to global address
> with VRF") takes care of this, so the sdif does not need checking here.
>
> This fix makes ping to link-local consistent with that to global
> addresses, in that this can now be done from within the same VRF that
> the address is in.
>
> Signed-off-by: Mike Manning <mmanning@vyatta.att-mail.com>
> ---
> net/ipv6/ipv6_sockglue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2018-11-07 3:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 19:10 [PATCH net-next v4 0/9] vrf: allow simultaneous service instances in default and other VRFs Mike Manning
2018-11-02 19:10 ` [PATCH net-next v4 1/9] net: allow binding socket in a VRF when there's an unbound socket Mike Manning
2018-11-06 17:52 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 2/9] net: ensure unbound stream socket to be chosen when not in a VRF Mike Manning
2018-11-06 17:55 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 3/9] net: ensure unbound datagram " Mike Manning
2018-11-06 17:59 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 4/9] net: provide a sysctl raw_l3mdev_accept for raw socket lookup with VRFs Mike Manning
2018-11-06 18:05 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 5/9] net: fix raw socket lookup device bind matching " Mike Manning
2018-11-06 18:08 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 6/9] vrf: mark skb for multicast or link-local as enslaved to VRF Mike Manning
2018-11-06 18:13 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 7/9] ipv6: allow ping to link-local address in VRF Mike Manning
2018-11-06 18:14 ` David Ahern [this message]
2018-11-02 19:10 ` [PATCH net-next v4 8/9] ipv6: handling of multicast packets received " Mike Manning
2018-11-06 18:24 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 9/9] ipv6: do not drop vrf udp multicast packets Mike Manning
2018-11-06 18:24 ` David Ahern
2018-11-04 15:52 ` [PATCH net-next v4 0/9] vrf: allow simultaneous service instances in default and other VRFs David Ahern
2018-11-04 18:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d5db1e7-53be-729c-cfdd-b634e97e2bc3@gmail.com \
--to=dsahern@gmail.com \
--cc=mmanning@vyatta.att-mail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).