From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth Date: Mon, 21 May 2018 08:19:20 -0700 Message-ID: <7d73f1b8-453a-fcbe-a1b8-41ced652deb0@gmail.com> References: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> <1526909293-56377-5-git-send-email-michal.vokac@ysoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net To: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= , netdev@vger.kernel.org, michal.vokac@ysoft.com Return-path: In-Reply-To: <1526909293-56377-5-git-send-email-michal.vokac@ysoft.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 05/21/2018 06:28 AM, Michal Vokáč wrote: > By default autonegotiation is enabled to configure MAC on all ports. > For the CPU port autonegotiation can not be used so we need to set > some sensible defaults manually. > > This patch forces the default setting of the CPU port to 1000Mbps/full > duplex which is the chip maximum capability. > > Also correct size of the bit field used to configure link speed. > > Signed-off-by: Michal Vokáč Reviewed-by: Florian Fainelli Likewise, would not we want to have a: Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family") tag here as well? -- Florian