From: Sagi Grimberg <sagi@grimberg.me>
To: Saeed Mahameed <saeedm@mellanox.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Qing Huang <qing.huang@oracle.com>
Subject: Re: [net 02/11] net/mlx5: Fix get vector affinity helper function
Date: Sun, 14 Jan 2018 11:29:33 +0200 [thread overview]
Message-ID: <7d906349-112f-50e1-2122-f2e5815bae76@grimberg.me> (raw)
In-Reply-To: <20180112003723.19208-3-saeedm@mellanox.com>
Hi Saeed,
> mlx5_get_vector_affinity used to call pci_irq_get_affinity and after
> reverting the patch that sets the device affinity via PCI_IRQ_AFFINITY
> API, calling pci_irq_get_affinity becomes useless and it breaks RDMA
> mlx5 users. To fix this, this patch provides an alternative way to
> retrieve IRQ vector affinity using legacy IRQ API, following
> smp_affinity read procfs implementation.
>
> Fixes: 231243c82793 ("Revert mlx5: move affinity hints assignments to generic code")
> Fixes: a435393acafb ("mlx5: move affinity hints assignments to generic code")
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Qing Huang <qing.huang@oracle.com>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
I didn't have time to test it out thus far, I assume you tested it
though, so looks good to me,
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
next prev parent reply other threads:[~2018-01-14 9:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 0:37 [pull request][net 00/11] Mellanox, mlx5 fixes 2018-01-11 Saeed Mahameed
2018-01-12 0:37 ` [net 01/11] {net,ib}/mlx5: Don't disable local loopback multicast traffic when needed Saeed Mahameed
2018-01-12 0:37 ` [net 02/11] net/mlx5: Fix get vector affinity helper function Saeed Mahameed
2018-01-14 9:29 ` Sagi Grimberg [this message]
2018-01-12 0:37 ` [net 03/11] net/mlx5: Fix memory leak in bad flow of mlx5_alloc_irq_vectors Saeed Mahameed
2018-01-12 0:37 ` [net 04/11] net/mlx5: Fix mlx5_get_uars_page to return error code Saeed Mahameed
2018-01-12 0:37 ` [net 05/11] net/mlx5: Fix error handling in load one Saeed Mahameed
2018-01-12 0:37 ` [net 06/11] net/mlx5e: Keep updating ethtool statistics when the interface is down Saeed Mahameed
2018-01-12 0:37 ` [net 07/11] net/mlx5e: Add error print in ETS init Saeed Mahameed
2018-01-12 0:37 ` [net 08/11] net/mlx5e: Check support before TC swap " Saeed Mahameed
2018-01-12 0:37 ` [net 09/11] net/mlx5e: Don't override netdev features field unless in error flow Saeed Mahameed
2018-01-12 0:37 ` [net 10/11] net/mlx5: Update ptp_clock_event foreach PPS event Saeed Mahameed
2018-01-12 0:37 ` [net 11/11] net/mlx5e: Remove timestamp set from netdevice open flow Saeed Mahameed
2018-01-12 15:41 ` [pull request][net 00/11] Mellanox, mlx5 fixes 2018-01-11 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d906349-112f-50e1-2122-f2e5815bae76@grimberg.me \
--to=sagi@grimberg.me \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=qing.huang@oracle.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).