From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
Felix Maurer <fmaurer@redhat.com>,
mptcp@lists.linux.dev
Subject: Re: [PATCHv3 bpf-next 2/2] selftests/bpf: run mptcp in a dedicated netns
Date: Fri, 24 Feb 2023 10:24:14 +0100 [thread overview]
Message-ID: <7dba2833-04ec-f59f-0b2f-64912f70bc7f@tessares.net> (raw)
In-Reply-To: <20230224061343.506571-3-liuhangbin@gmail.com>
Hi Hangbin,
Thank you for this new version!
On 24/02/2023 07:13, Hangbin Liu wrote:
> The current mptcp test is run in init netns. If the user or default
> system config disabled mptcp, the test will fail. Let's run the mptcp
> test in a dedicated netns to avoid none kernel default mptcp setting.
(...)
> + SYS_NOFAIL("ip netns del " NS_TEST " &> /dev/null");
"Funny", I saw the ">&" in a previous versions and I was going to react
before noticing this is in fact valid in Bash (and ZSH). But of course I
should have checked with 'sh' instead...
Anyway, Martin: thank you for having spotted that!
Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2023-02-24 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 6:13 [PATCHv3 bpf-next 0/2] move SYS() macro to test_progs.h and run mptcp in a dedicated netns Hangbin Liu
2023-02-24 6:13 ` [PATCHv3 bpf-next 1/2] selftests/bpf: move SYS() macro into the test_progs.h Hangbin Liu
2023-02-24 6:13 ` [PATCHv3 bpf-next 2/2] selftests/bpf: run mptcp in a dedicated netns Hangbin Liu
2023-02-24 9:24 ` Matthieu Baerts [this message]
2023-02-25 1:40 ` [PATCHv3 bpf-next 0/2] move SYS() macro to test_progs.h and " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dba2833-04ec-f59f-0b2f-64912f70bc7f@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=fmaurer@redhat.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=martin.lau@linux.dev \
--cc=mptcp@lists.linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).