From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11BBDC677F1 for ; Fri, 24 Feb 2023 09:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbjBXJYY (ORCPT ); Fri, 24 Feb 2023 04:24:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjBXJYX (ORCPT ); Fri, 24 Feb 2023 04:24:23 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7FAD5DCCA for ; Fri, 24 Feb 2023 01:24:21 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id d30so11089371eda.4 for ; Fri, 24 Feb 2023 01:24:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares.net; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sTweRjc8yOnKd0wjXCLkcU3l1xjeg/lfkkZ4yVcU0+I=; b=lAW36uHb21iACHYo5y0767OorPNQyOVChBjbKQXEz7UbflVipMZmuNBkb5a++ifQMi miKaR7O4KdoFbaBwsa0THkJIVpyxM7m9/8rzqqnqzqo2guyTh2O/MJ3pJ1jj6MhmizOQ 2UFVBs8BHG8p0thtikLhm1G3slZaxmq5Sw9QBbTZX+b2mELlokJyuWWH8OxwCvuvkmtb UVP+u2s0B2d3z5D4IoxMWEXcnOHVDySOY1qnleR7rA4M/PdG55/bnYANIL3qpklSy3Ev jinwMlrjvYXKXV+3WUADCFGBOCV3ZpbpF8RiW/pKiEEizExoTm2nfrNVQ+MvulCPaoLe R/5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sTweRjc8yOnKd0wjXCLkcU3l1xjeg/lfkkZ4yVcU0+I=; b=H95mQggWQlHurX1IeefE+z1d+tkw7QrCedYD5mhkjZiGUtYA9LbVAnsryqsP8anhSf zb18f57/sf8Tj3M9F+r9JWKYBGWoV/YLm0xSm8LJYEeIcmOo+P3P0EvvdSpggB5jtUYa NbcB983WI1B/u4S2LeHxJYgNhdSiQxd9YkRaUKSl5wkRU7X7brOd2Z6gSOExFkDndTgM iGORiQKI63uew4OkmbXX3ZVSOXC3jCTXRC9MS6gecrjvu82xcMSrX2F7OD8e8EfU24TT p3D7QhX22W7sjCRjU6qWBPP2U0VP7ZrVSp0CDF+b5dG+5EAgLDjJX0YEWHc2iq3s/JrW 236A== X-Gm-Message-State: AO0yUKWLJCANT6r9cmfFRNzZ/MLf+o8DDVAKH+jn2YZvMum4bT2HAPXI z3nIq6CPJ+gwkYCOrIz1RIeO1Q== X-Google-Smtp-Source: AK7set+LQUlpGYF4mH0Seww8ZBljv26E7b+3K+NxIP/8qiSepghYnSTxsefRs1ucyl9ESWWKX78+fA== X-Received: by 2002:a05:6402:756:b0:4af:6c25:f028 with SMTP id p22-20020a056402075600b004af6c25f028mr4629896edy.5.1677230660144; Fri, 24 Feb 2023 01:24:20 -0800 (PST) Received: from [10.44.2.5] (84-199-106-91.ifiber.telenet-ops.be. [84.199.106.91]) by smtp.gmail.com with ESMTPSA id t17-20020a50d711000000b004af596a6bfcsm4003815edi.26.2023.02.24.01.24.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 01:24:19 -0800 (PST) Message-ID: <7dba2833-04ec-f59f-0b2f-64912f70bc7f@tessares.net> Date: Fri, 24 Feb 2023 10:24:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCHv3 bpf-next 2/2] selftests/bpf: run mptcp in a dedicated netns Content-Language: en-GB To: Hangbin Liu , netdev@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , bpf@vger.kernel.org, Jakub Kicinski , "David S . Miller" , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Felix Maurer , mptcp@lists.linux.dev References: <20230224061343.506571-1-liuhangbin@gmail.com> <20230224061343.506571-3-liuhangbin@gmail.com> From: Matthieu Baerts In-Reply-To: <20230224061343.506571-3-liuhangbin@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Hangbin, Thank you for this new version! On 24/02/2023 07:13, Hangbin Liu wrote: > The current mptcp test is run in init netns. If the user or default > system config disabled mptcp, the test will fail. Let's run the mptcp > test in a dedicated netns to avoid none kernel default mptcp setting. (...) > + SYS_NOFAIL("ip netns del " NS_TEST " &> /dev/null"); "Funny", I saw the ">&" in a previous versions and I was going to react before noticing this is in fact valid in Bash (and ZSH). But of course I should have checked with 'sh' instead... Anyway, Martin: thank you for having spotted that! Acked-by: Matthieu Baerts Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net