From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Saeed Mahameed <saeed@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Mark Einon <mark.einon@gmail.com>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Shay Agroskin <shayagr@amazon.com>,
Arthur Kiyanovski <akiyano@amazon.com>,
David Arinzon <darinzon@amazon.com>,
Noam Dagan <ndagan@amazon.com>, Saeed Bishara <saeedb@amazon.com>,
Chris Snook <chris.snook@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Hans Ulli Kroll <ulli.kroll@googlemail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jeroen de Borst <jeroendb@google.com>,
Catherine Sullivan <csully@google.com>,
David Awogbemila <awogbemila@google.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"K . Y . Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Jon Mason <jdmason@kudzu.us>,
Simon Horman <simon.horman@corigine.com>,
Rain River <rain.1986.08.12@gmail.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
Shannon Nelson <snelson@pensando.io>,
drivers@pensando.io, Sergey Shtylyov <s.shtylyov@omp.ru>,
Jiri Pirko <jiri@resnulli.us>,
Edward Cree <ecree.xilinx@gmail.com>,
Martin Habets <habetsm.xilinx@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Andy Gospodarek <andy@greyhouse.net>,
Michal Simek <michal.simek@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Jacob Keller <jacob.e.keller@intel.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
Rob Herring <robh@kernel.org>,
l.stelmach@samsung.com, rafal@milecki.pl,
Edwin Peer <edwin.peer@broadcom.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Chan <michael.chan@broadcom.com>,
Richard Cochran <richardcochran@gmail.com>,
Gerhard Engleder <gerhard@engleder-embedded.com>,
Marcin Wojtas <mw@semihalf.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Gabriel Somlo <gsomlo@gmail.com>, Joel Stanley <joel@jms.id.au>,
Slark Xiao <slark_xiao@163.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Liming Sun <limings@nvidia.com>,
David Thompson <davthompson@nvidia.com>,
Asmaa Mnebhi <asmaa@nvidia.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Steen Hegelund <steen.hegelund@microchip.com>,
Prabhakar Kushwaha <pkushwaha@marvell.com>,
Omkar Kulkarni <okulkarni@marvell.com>,
Shai Malin <smalin@marvell.com>,
Randy Dunlap <rdunlap@infradead.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
Gary Guo <gary@garyguo.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, intel-wired-lan@lists.osuosl.org,
linux-hyperv@vger.kernel.org, oss-drivers@corigine.com,
linux-renesas-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH net-next] net: kbuild: Don't default net vendor configs to y
Date: Mon, 31 Jan 2022 15:06:01 -0800 [thread overview]
Message-ID: <7dc930c6-4ffc-0dd0-8385-d7956e7d16ff@gmail.com> (raw)
In-Reply-To: <20220131121027.4fe3e8dc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 1/31/2022 12:10 PM, Jakub Kicinski wrote:
> On Mon, 31 Jan 2022 10:40:38 -0800 Florian Fainelli wrote:
>>>> And changing the defaults means all defconfigs must be updated first,
>>>> else the user's configs will end up without drivers needed.
>>>>
>>>
>>> As I understand correctly, at least for most common net drivers, having
>>> NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per
>>> module for each vendor and those are defaulted to N.
>>
>> Right, but once you start hiding NET_VENDOR_DRIVER_XYZ under a
>> NET_VENDOR_XYZ Kconfig symbol dependency, if NET_VENDOR_XYZ is not set
>> to Y, then you have no way to select NET_VENDOR_DRIVER_XYZ and so your
>> old defconfig breaks.
>
> To be clear do we actually care about *old* configs or *def* configs?
I think we care about oldconfig but maybe less so about defconfigs which
are in tree and can be updated.
>
> Breaking defconfigs seems bad, but I don't think we can break
> reasonable oldconfigs at this point?
No preference either way for me, just like Richard, all of the systems I
typically work with either require a carefully curated configuration
file to strip out unwanted features. I do like Geert's suggestion of
adding default ARCH_ for slightly esoteric controllers that are not
found in off the shelf hardware.
>
>>>> It might make sense to tune some of the defaults (i.e. change to
>>>> "default y if ARCH_*") for drivers with clear platform dependencies.
>>>>
>>>
>>> either set hard default to 'n' or just keep it as is, anything else is just
>>> more confusion.
>>
>> Maybe the rule should go like this: any new driver vendor defaults to n,
>> and existing ones remain set to y, until we deprecate doing that and
>> switching them all off to n by 5.18?
>
> I'd be afraid that given the work of fixing up defconfigs is
> non-trivial we may end up never switching old drivers. And then we'd
> have a semi-random soup of defaults :(
Fair enough.
--
Florian
next prev parent reply other threads:[~2022-01-31 23:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 17:24 [PATCH net-next] net: kbuild: Don't default net vendor configs to y Saeed Mahameed
2022-01-31 17:59 ` Stephen Hemminger
2022-01-31 18:30 ` Geert Uytterhoeven
2022-01-31 18:35 ` Saeed Mahameed
2022-01-31 18:40 ` Florian Fainelli
2022-01-31 18:55 ` [Intel-wired-lan] " Hisashi T Fujinaka
2022-02-01 8:58 ` Leon Romanovsky
2022-02-01 15:46 ` Richard Cochran
2022-01-31 19:17 ` Richard Cochran
2022-01-31 20:10 ` Jakub Kicinski
2022-01-31 23:06 ` Florian Fainelli [this message]
2022-01-31 23:13 ` Jakub Kicinski
2022-01-31 23:19 ` Florian Fainelli
2022-02-02 4:46 ` Saeed Mahameed
2022-02-02 4:58 ` Jakub Kicinski
2022-02-02 5:16 ` Saeed Mahameed
2022-02-02 6:30 ` Christophe Leroy
2022-02-02 6:44 ` Saeed Mahameed
2022-02-02 6:49 ` Saeed Mahameed
2022-02-02 15:17 ` Richard Cochran
2022-02-02 15:31 ` Arnd Bergmann
2022-01-31 18:31 ` Saeed Mahameed
2022-01-31 18:04 ` Shannon Nelson
2022-01-31 19:13 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dc930c6-4ffc-0dd0-8385-d7956e7d16ff@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Jose.Abreu@synopsys.com \
--cc=LinoSanfilippo@gmx.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=akiyano@amazon.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andy@greyhouse.net \
--cc=anthony.l.nguyen@intel.com \
--cc=arnd@arndb.de \
--cc=asmaa@nvidia.com \
--cc=awogbemila@google.com \
--cc=chris.snook@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@microchip.com \
--cc=claudiu.manoil@nxp.com \
--cc=csully@google.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=decui@microsoft.com \
--cc=drivers@pensando.io \
--cc=ecree.xilinx@gmail.com \
--cc=edwin.peer@broadcom.com \
--cc=gary@garyguo.net \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=gerhard@engleder-embedded.com \
--cc=gsomlo@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=horatiu.vultur@microchip.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jdmason@kudzu.us \
--cc=jernej.skrabec@gmail.com \
--cc=jeroendb@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=l.stelmach@samsung.com \
--cc=lars.povlsen@microchip.com \
--cc=limings@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux@rempel-privat.de \
--cc=mark.einon@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=michal.simek@xilinx.com \
--cc=mripard@kernel.org \
--cc=mw@semihalf.com \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=okulkarni@marvell.com \
--cc=oss-drivers@corigine.com \
--cc=pkushwaha@marvell.com \
--cc=rafal@milecki.pl \
--cc=rain.1986.08.12@gmail.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=saeed@kernel.org \
--cc=saeedb@amazon.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=shayagr@amazon.com \
--cc=simon.horman@corigine.com \
--cc=slark_xiao@163.com \
--cc=smalin@marvell.com \
--cc=snelson@pensando.io \
--cc=steen.hegelund@microchip.com \
--cc=stefan.wahren@i2se.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=ulli.kroll@googlemail.com \
--cc=vegard.nossum@oracle.com \
--cc=vigneshr@ti.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.liu@kernel.org \
--cc=wens@csie.org \
--cc=yisen.zhuang@huawei.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).