From: Paolo Abeni <pabeni@redhat.com>
To: Philo Lu <lulie@linux.alibaba.com>, netdev@vger.kernel.org
Cc: willemdebruijn.kernel@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, dsahern@kernel.org,
antony.antony@secunet.com, steffen.klassert@secunet.com,
linux-kernel@vger.kernel.org, dust.li@linux.alibaba.com,
jakub@cloudflare.com, fred.cc@alibaba-inc.com,
yubing.qiuyubing@alibaba-inc.com
Subject: Re: [PATCH v4 net-next 2/3] net/udp: Add 4-tuple hash list basis
Date: Wed, 16 Oct 2024 09:45:29 +0200 [thread overview]
Message-ID: <7dde23ec-e813-4495-a0ca-6ed0f1276aa6@redhat.com> (raw)
In-Reply-To: <2888bb8f-1ee4-4342-968f-82573d583709@linux.alibaba.com>
On 10/16/24 08:30, Philo Lu wrote:
> On 2024/10/14 18:07, Paolo Abeni wrote:
>> It would be great if you could please share some benchmark showing the
>> raw max receive PPS performances for unconnected sockets, with and
>> without this series applied, to ensure this does not cause any real
>> regression for such workloads.
>>
>
> Tested using sockperf tp with default msgsize (14B), 3 times for w/ and
> w/o the patch set, and results show no obvious difference:
>
> [msg/sec] test1 test2 test3 mean
> w/o patch 514,664 519,040 527,115 520.3k
> w/ patch 516,863 526,337 527,195 523.5k (+0.6%)
>
> Thank you for review, Paolo.
Are the value in packet per seconds, or bytes per seconds? Are you doing
a loopback test or over the wire? The most important question is: is the
receiver side keeping (at least) 1 CPU fully busy? Otherwise the test is
not very relevant.
It looks like you have some setup issue, or you are using a relatively
low end H/W: the expected packet rate for reasonable server H/W is well
above 1M (possibly much more than that, but I can't put my hands on
recent H/W, so I can't provide a more accurate figure).
A single socket, user-space, UDP sender is usually unable to reach such
tput without USO, and even with USO you likely need to do an
over-the-wire test to really be able to keep the receiver fully busy.
AFAICS sockperf does not support USO for the sender.
You could use the udpgso_bench_tx/udpgso_bench_rx pair from the net
selftests directory instead.
Or you could use pktgen as traffic generator.
Thanks,
Paolo
next prev parent reply other threads:[~2024-10-16 7:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 1:29 [PATCH v4 net-next 0/3] udp: Add 4-tuple hash for connected sockets Philo Lu
2024-10-12 1:29 ` [PATCH v4 net-next 1/3] net/udp: Add a new struct for hash2 slot Philo Lu
2024-10-12 1:29 ` [PATCH v4 net-next 2/3] net/udp: Add 4-tuple hash list basis Philo Lu
2024-10-14 10:07 ` Paolo Abeni
2024-10-16 6:30 ` Philo Lu
2024-10-16 7:45 ` Paolo Abeni [this message]
2024-10-16 8:47 ` Philo Lu
2024-10-17 7:46 ` Philo Lu
2024-10-12 1:29 ` [PATCH v4 net-next 3/3] ipv4/udp: Add 4-tuple hash for connected socket Philo Lu
2024-10-14 10:19 ` Paolo Abeni
2024-10-16 7:28 ` Philo Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dde23ec-e813-4495-a0ca-6ed0f1276aa6@redhat.com \
--to=pabeni@redhat.com \
--cc=antony.antony@secunet.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=fred.cc@alibaba-inc.com \
--cc=jakub@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yubing.qiuyubing@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).