From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22673C4360C for ; Sun, 29 Sep 2019 12:21:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE37D2082F for ; Sun, 29 Sep 2019 12:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727411AbfI2MVs (ORCPT ); Sun, 29 Sep 2019 08:21:48 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3172 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725924AbfI2MVs (ORCPT ); Sun, 29 Sep 2019 08:21:48 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id F1C9CB4A00544FB17528; Sun, 29 Sep 2019 20:21:44 +0800 (CST) Received: from [127.0.0.1] (10.74.191.121) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Sun, 29 Sep 2019 20:21:37 +0800 Subject: Re: [question] About triggering a region snapshot through the devlink cmd To: Jiri Pirko CC: , , , "netdev@vger.kernel.org" , "linuxarm@huawei.com" References: <20190927081333.GF3742@nanopsycho> From: Yunsheng Lin Message-ID: <7e013acc-8506-87a5-1c73-67703b9aa5ff@huawei.com> Date: Sun, 29 Sep 2019 20:21:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20190927081333.GF3742@nanopsycho> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.191.121] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/9/27 16:13, Jiri Pirko wrote: > Fri, Sep 27, 2019 at 09:40:47AM CEST, linyunsheng@huawei.com wrote: >> Hi, Jiri & Alex >> >> It seems that a region' snapshot is only created through the >> driver when some error is detected, for example: >> mlx4_crdump_collect_fw_health() -> devlink_region_snapshot_create() >> >> We want to trigger a region' snapshot creation through devlink >> cmd, maybe by adding the "devlink region triger", because we want >> to check some hardware register/state when the driver or the hardware >> does not detect the error sometimes. >> >> Does about "devlink region triger" make sense? >> >> If yes, is there plan to implement it? or any suggestion to implement >> it? > > Actually, the plan is co convert mlx4 to "devlink health" api. Mlx5 > already uses that. > > You should look into "devlink health". Thanks for mentioning the "devlink health" api. I has sent a RFC adding the support of the dump hardware mac table. Please have a look, any comment or suggestion will be very helpful. > >> > >