From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johann Baudy Subject: Re: [PATCH] TX_RING and packet mmap Date: Sun, 12 Apr 2009 22:30:34 +0200 Message-ID: <7e0dd21a0904121330p3fe9b27bx1cd16a6c8fb9b574@mail.gmail.com> References: <1239112067.32737.51.camel@dogo.mojatatu.com> <1239137800.21227.10.camel@dogo.mojatatu.com> <20090407211130.GA5918@ioremap.net> <7e0dd21a0904081406w31da460pe1c0c7153538f283@mail.gmail.com> <7e0dd21a0904120327q537956abkf75a17d477cc2e61@mail.gmail.com> <20090412103212.GA28397@ioremap.net> <7e0dd21a0904120423v4296898fl7ce82ec8c3e42d3a@mail.gmail.com> <20090412142451.GA2694@ioremap.net> <7e0dd21a0904121227n3b03f2c7v8bf30c45667603a1@mail.gmail.com> <20090412195203.GA11899@ioremap.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Herbert Xu , netdev@vger.kernel.org, "David S. Miller" , Patrick McHardy , jamal To: Evgeniy Polyakov Return-path: Received: from mail-bw0-f169.google.com ([209.85.218.169]:39659 "EHLO mail-bw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbZDLUag convert rfc822-to-8bit (ORCPT ); Sun, 12 Apr 2009 16:30:36 -0400 Received: by bwz17 with SMTP id 17so1798182bwz.37 for ; Sun, 12 Apr 2009 13:30:34 -0700 (PDT) In-Reply-To: <20090412195203.GA11899@ioremap.net> Sender: netdev-owner@vger.kernel.org List-ID: Where do you see that skb_shinfo(skb)->frags[i].page (not other fields) can be overwritten ? Thanks, Johann On Sun, Apr 12, 2009 at 9:52 PM, Evgeniy Polyakov wro= te: > On Sun, Apr 12, 2009 at 09:27:37PM +0200, Johann Baudy (johann.baudy@= gnu-log.net) wrote: >> I've seen that during skb_linearize(), skb_shinfo(skb)->frags[i].pag= e >> is not lost even if pages has been put. So I can get back original >> frag address from this info in skb destructor. Can I rely on >> skb_shinfo(skb)->frags[i].page on more complicated sending paths ...= ? > > skb_shinfo(skb)->frags[i] can be overwritten, for example in > __pskb_pull_tail() at pull_pages: label. > > -- > =A0 =A0 =A0 =A0Evgeniy Polyakov > --=20 Johann Baudy johaahn@gmail.com