netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johann Baudy <johann.baudy@gnu-log.net>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Patrick McHardy <kaber@trash.net>, jamal <hadi@cyberus.ca>
Subject: Re: [PATCH] TX_RING and packet mmap
Date: Mon, 13 Apr 2009 01:31:14 +0200	[thread overview]
Message-ID: <7e0dd21a0904121631u3fc7c676r12eb7e71fe87e02b@mail.gmail.com> (raw)
In-Reply-To: <20090412205334.GA14345@ioremap.net>

Thanks Evgeniy,

So if my understanding is correct, there is no way to get original
fragment address in destructor using skb fragment page/data.

Then,
I can't use fragments due to skb_linearize
I can't hide pointer into skb data due to skb_copy.
I can't rely on other fields of skb.
IMHO, using skb pointer requires too much cpu resources (parsing
headers to identify the right buffer...)

So what can I do except using a new field?
What do you think about adding a new field that is always linked to destructor?
I mean adding a generic new field skb->destructor_arg.

Currently if someone want to change destructor, it stores old
destructor before substitution; and executes it at the end of new
destructor. (ex: dev_gso_skb_destructor(struct sk_buff *skb))

Can we just add same mechanism for a new argument?
If someone needs destructor_arg, it saves the old value somewhere; and
restores it before calling old destructor (in the new destructor).
This way everybody can forward data to his destructor properly.

 Is it conceivable?

Thanks for your help,
Johann


-- 
Johann Baudy
johaahn@gmail.com

  reply	other threads:[~2009-04-12 23:31 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02 19:48 [PATCH] TX_RING and packet mmap Johann Baudy
2009-04-07  7:26 ` Herbert Xu
2009-04-07 12:48   ` jamal
2009-04-07 13:04     ` Herbert Xu
2009-04-07 13:47       ` jamal
2009-04-07 14:17         ` Herbert Xu
2009-04-07 14:40         ` Johann Baudy
     [not found]         ` <7e0dd21a0904070738jd8a2714wd840352699f1e9f1@mail.gmail.com>
2009-04-07 20:56           ` jamal
2009-04-07 21:11             ` Evgeniy Polyakov
2009-04-08 21:06               ` Johann Baudy
2009-04-12 10:27                 ` Johann Baudy
2009-04-12 10:32                   ` Evgeniy Polyakov
2009-04-12 11:23                     ` Johann Baudy
2009-04-12 14:24                       ` Evgeniy Polyakov
2009-04-12 19:27                         ` Johann Baudy
2009-04-12 19:52                           ` Evgeniy Polyakov
2009-04-12 20:30                             ` Johann Baudy
2009-04-12 20:53                               ` Evgeniy Polyakov
2009-04-12 23:31                                 ` Johann Baudy [this message]
2009-04-15  7:10                                   ` Evgeniy Polyakov
2009-04-15 13:14                                     ` Johann Baudy
2009-04-16 11:16                                       ` Evgeniy Polyakov
2009-04-18 21:38                                         ` Johann Baudy
2009-04-21  9:41                                           ` Evgeniy Polyakov
2009-04-21 13:16                                             ` Johann Baudy
2009-04-21 13:56                                               ` Evgeniy Polyakov
2009-04-08  6:51           ` Herbert Xu
2009-04-21 15:36 ` Christoph Lameter
2009-04-21 20:13   ` Johann Baudy
2009-04-21 20:42     ` Christoph Lameter
2009-04-21 21:00       ` Johann Baudy
2009-04-21 21:00         ` Christoph Lameter
2009-04-21 21:13           ` Johann Baudy
2009-04-21 20:46     ` Johann Baudy
2009-04-21 20:43       ` Christoph Lameter
2009-04-21 21:05         ` Johann Baudy
2009-04-21 21:08           ` Christoph Lameter
  -- strict thread matches above, loose matches on Subject: below --
2009-04-26 13:06 Johann Baudy
2009-04-29  9:18 ` Evgeniy Polyakov
2009-04-30 20:17   ` Johann Baudy
2009-05-05 21:38 Johann Baudy
2009-05-06  7:07 ` Jarek Poplawski
2009-05-06  9:38   ` Jarek Poplawski
2009-05-09 20:31 ` David Miller
2009-05-11 21:21 Johann Baudy
2009-05-12 16:11 ` Andi Kleen
     [not found]   ` <7e0dd21a0905121058m1f894de6q9805e5392aef3aea@mail.gmail.com>
2009-05-12 18:00     ` Johann Baudy
     [not found]     ` <7e0dd21a0905121058m1f894de6q9805e5392aef3aea-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-12 18:15       ` Andi Kleen
2009-05-19  5:12 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e0dd21a0904121631u3fc7c676r12eb7e71fe87e02b@mail.gmail.com \
    --to=johann.baudy@gnu-log.net \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=herbert@gondor.apana.org.au \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).