From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [iproute2-next 1/1] tipc: fixed node and name table listings Date: Wed, 9 May 2018 21:57:11 -0600 Message-ID: <7e1086cd-292b-bd80-fdbb-f0840945f337@gmail.com> References: <1525710766-26122-1-git-send-email-jon.maloy@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: mohan.krishna.ghanta.krishnamurthy@ericsson.com, tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au, canh.d.luu@dektech.com.au, ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net To: Jon Maloy , stephen@networkplumber.org, netdev@vger.kernel.org Return-path: Received: from mail-pf0-f177.google.com ([209.85.192.177]:34668 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756220AbeEJD5O (ORCPT ); Wed, 9 May 2018 23:57:14 -0400 Received: by mail-pf0-f177.google.com with SMTP id a14-v6so409652pfi.1 for ; Wed, 09 May 2018 20:57:13 -0700 (PDT) In-Reply-To: <1525710766-26122-1-git-send-email-jon.maloy@ericsson.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/7/18 10:32 AM, Jon Maloy wrote: > We make it easier for users to correlate between 128-bit node > identities and 32-bit node hash by extending the 'node list' > command to also show the hash value. > > We also improve the 'nametable show' command to show the node identity > instead of the node hash value. Since the former potentially is much > longer than the latter, we make room for it by eliminating the (to the > user) irrelevant publication key. We also reorder some of the columns > so that the node id comes last, since this looks nicer and more logical. > > Signed-off-by: Jon Maloy > --- > tipc/misc.c | 18 ++++++++++++++++++ > tipc/misc.h | 1 + > tipc/nametable.c | 18 ++++++++++-------- > tipc/node.c | 19 ++++++++----------- > tipc/peer.c | 4 ++++ > 5 files changed, 41 insertions(+), 19 deletions(-) > Hi Jon: I see new warnings with Debian stretch gcc: tipc CC misc.o CC nametable.o CC node.o CC peer.o misc.c: In function ‘hash2nodestr’: misc.c:128:14: warning: pointer targets in passing argument 1 of ‘nodeid2str’ differ in signedness [-Wpointer-sign] nodeid2str(nr.node_id, str); ^~ misc.c:100:6: note: expected ‘uint8_t * {aka unsigned char *}’ but argument is of type ‘char *’ void nodeid2str(uint8_t *id, char *str) ^~~~~~~~~~