From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [Patch net] ip6mr: avoid double unregister of pim6reg device Date: Fri, 21 Apr 2017 23:25:38 +0300 Message-ID: <7e163700-fa62-5663-26a2-16e87cd31a03@cumulusnetworks.com> References: <1492802839-16851-1-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Linux Kernel Network Developers , Andrey Konovalov , Linus Torvalds To: Cong Wang Return-path: Received: from mail-wr0-f177.google.com ([209.85.128.177]:36504 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1040579AbdDUUZl (ORCPT ); Fri, 21 Apr 2017 16:25:41 -0400 Received: by mail-wr0-f177.google.com with SMTP id c55so60949918wrc.3 for ; Fri, 21 Apr 2017 13:25:41 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 21/04/17 23:20, Cong Wang wrote: > On Fri, Apr 21, 2017 at 12:34 PM, Nikolay Aleksandrov > wrote: >> On 21/04/17 22:27, Cong Wang wrote: >>> If we unregister the pim6reg device via default_device_exit_batch(), >>> we will receive a notification and ip6mr_device_event() will >>> unregister it again. This causes a kernel BUG at net/core/dev.c:6813. >>> >>> Like commit 7dc00c82cbb0 ("ipv4: Fix ipmr unregister device oops") >>> we should avoid double-unregister in netdevice notifier. >>> >>> Reported-by: Andrey Konovalov >>> Cc: Linus Torvalds >>> Signed-off-by: Cong Wang >>> --- >>> net/ipv6/ip6mr.c | 11 ++++++----- >>> 1 file changed, 6 insertions(+), 5 deletions(-) >>> >> >> Cong, >> Please read the full thread, I've already provided a fix which is similar. >> https://patchwork.ozlabs.org/patch/753531/ > > You beat me on that. ;) You should leave a reply to Andrey's report > otherwise people could miss it. > The patch was sent as a reply to the original report. :-)