From: David Ahern <dsa@cumulusnetworks.com>
To: 张胜举 <zhangshengju@cmss.chinamobile.com>, netdev@vger.kernel.org
Subject: Re: [net,v2] neigh: fix the loop index error in neigh dump
Date: Sun, 27 Nov 2016 22:07:28 -0700 [thread overview]
Message-ID: <7e3623c4-a55e-5809-ca9a-2dbd59cda871@cumulusnetworks.com> (raw)
In-Reply-To: <001e01d24932$f7c0dd10$e7429730$@cmss.chinamobile.com>
On 11/27/16 9:50 PM, 张胜举 wrote:
> No, when dump request must be processed by multiple 'recv/recvmsg' system
> calls,
> idx stores which dev/neigh the previous call have processed, so that next
> call will scan
> from the right place.
I have tested multiple calls and I do not see redundant information or missing information.
>
> So no matter whether the dev/neigh is filtered, the idx should be increased
> anyway.
No, it does not. Again, idx is the index in the list of devices/ of interest. It is NOT a device index nor is it the absolute index in the list. It is a relative index. The filter is the same across recvmsg calls so the idx count is absolutely fine.
Produce a test case that fails.
next prev parent reply other threads:[~2016-11-28 5:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 1:32 [net,v2] neigh: fix the loop index error in neigh dump Zhang Shengju
2016-11-28 2:09 ` David Ahern
2016-11-28 2:34 ` 张胜举
2016-11-28 2:39 ` David Ahern
2016-11-28 2:53 ` 张胜举
2016-11-28 2:56 ` David Ahern
2016-11-28 3:09 ` David Ahern
2016-11-28 4:50 ` 张胜举
2016-11-28 5:07 ` David Ahern [this message]
2016-11-28 6:28 ` 张胜举
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e3623c4-a55e-5809-ca9a-2dbd59cda871@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox