From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF3ACC433DB for ; Fri, 8 Jan 2021 18:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72DDA23A7E for ; Fri, 8 Jan 2021 18:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728768AbhAHScf (ORCPT ); Fri, 8 Jan 2021 13:32:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727686AbhAHSce (ORCPT ); Fri, 8 Jan 2021 13:32:34 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77CF0C061381 for ; Fri, 8 Jan 2021 10:31:54 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id b8so6121798plx.0 for ; Fri, 08 Jan 2021 10:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MHha8esqBvN69/8JH8dAoEXVd97RlxgY9vW/1xU6L9c=; b=aqjB5j8TTSudG7fEkA7vQN4ZF1/14xftQi8/Jullpr6a9qbyksPloia+o35JHK7q0q e+IbxFqxK7qf5/vkm1ukE1xJ9VPbTg6jXzTAt80c852Q+WBRN1Z0sfyzsGoc1GRzn9Ii 17oo/PN/OAMThpwIc0Y8fs5UnreKIeY5N212+e0oSpqFR8YVoX9cl9QPsiEij1PDfsN9 YADwHvLDUuwsSSuMcragdQY7dODi28jKkgxlnEK72eOzo5tmfwYTnjO6BZw2VRpBMBbw +uGzkJXJswqDJ2qGhizWctzd5LH2lTvB4V95rWTsk1Y7SE4kT56egNTXbetwgC3xZHV+ vFDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MHha8esqBvN69/8JH8dAoEXVd97RlxgY9vW/1xU6L9c=; b=hEEVmVyoDi6MvbewamAH8s9wvehd9QoGx5YctfZGbu+kblbvr3nPrVLC7Ko86lM4Kb LuQ9FStaIOIYoWayzF1RJAQjDA5uJLqIbDt9779cLISCMcCCTGmVDWXny36bQjlUNUHN ME+TTuUfwq0Aw1AJILdAVxCUIbqG+vHTRUtPoM8sYoOqEQaUgw4ZiDRMjQzA9uE06Cc4 8u50sMT+I1SoGQAVH1T0Lc/e0YhnLSkKbmAFr9RwxhzZKDGH6ccJ1u/G8HhypJMJr9Sl Q9HKVorXAQ227gUQIynzZEjmMRzlYJyUPOzUZombVvqLHSxOc/Craw9PD4vfh6TgpYUE O4qw== X-Gm-Message-State: AOAM533tx6yYNof5/vmMvTDCu65oseOaOObYxxuTH8K7GTyjd41Lf8+G IRxE7wowozhF/j46QQE7j/8= X-Google-Smtp-Source: ABdhPJwgu5/H+RfxB+ILk07/i6Q/TETlmkfr4XdjcjpKqW7etYU5J+mJRFAKO5HmKg41xWrLyDfzzQ== X-Received: by 2002:a17:902:9f88:b029:dc:292d:37c5 with SMTP id g8-20020a1709029f88b02900dc292d37c5mr5066111plq.26.1610130714048; Fri, 08 Jan 2021 10:31:54 -0800 (PST) Received: from [10.230.29.29] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id b189sm9225164pfb.194.2021.01.08.10.31.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jan 2021 10:31:53 -0800 (PST) Subject: Re: [PATCH v3 net-next 03/10] net: dsa: add ops for devlink-sb To: Vladimir Oltean , netdev@vger.kernel.org Cc: alexandre.belloni@bootlin.com, andrew@lunn.ch, vivien.didelot@gmail.com, alexandru.marginean@nxp.com, claudiu.manoil@nxp.com, xiaoliang.yang_1@nxp.com, hongbo.wang@nxp.com, kuba@kernel.org, jiri@resnulli.us, idosch@idosch.org, UNGLinuxDriver@microchip.com References: <20210108175950.484854-1-olteanv@gmail.com> <20210108175950.484854-4-olteanv@gmail.com> From: Florian Fainelli Message-ID: <7e36b837-3e0f-df60-14c0-6c028b8bbf9c@gmail.com> Date: Fri, 8 Jan 2021 10:31:51 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210108175950.484854-4-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/8/2021 9:59 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Switches that care about QoS might have hardware support for reserving > buffer pools for individual ports or traffic classes, and configuring > their sizes and thresholds. Through devlink-sb (shared buffers), this is > all configurable, as well as their occupancy being viewable. > > Add the plumbing in DSA for these operations. > > Individual drivers still need to call devlink_sb_register() with the > shared buffers they want to expose. A helper was not created in DSA for > this purpose (unlike, say, dsa_devlink_params_register), since in my > opinion it does not bring any benefit over plainly calling > devlink_sb_register() directly. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian